Skip to content

Add immediate observer callback invokation#209

Merged
dphfox merged 2 commits into
dphfox:mainfrom
krypt102:immediate-observer-invokation
Feb 1, 2023
Merged

Add immediate observer callback invokation#209
dphfox merged 2 commits into
dphfox:mainfrom
krypt102:immediate-observer-invokation

Conversation

@krypt102

@krypt102 krypt102 commented Feb 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #166
Basically just runs the callback immediately while still providing a disconnect function.
Will be a draft for the moment until I implement disconnecting

@krypt102 krypt102 marked this pull request as draft February 1, 2023 05:02
@krypt102 krypt102 marked this pull request as ready for review February 1, 2023 05:05
@krypt102

krypt102 commented Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

Nevermind, that was surprisingly easier than I thought

@dphfox dphfox added ready to work on Enhancements/changes ready to be made area: state not ready - blocked Waiting on other work to be done and removed ready to work on Enhancements/changes ready to be made not ready - blocked Waiting on other work to be done labels Feb 1, 2023
@dphfox

dphfox commented Feb 1, 2023

Copy link
Copy Markdown
Owner

Looks good to me :)

@dphfox dphfox merged commit b62d7e7 into dphfox:main Feb 1, 2023
@dphfox dphfox mentioned this pull request Feb 1, 2023
Closed
@krypt102 krypt102 deleted the immediate-observer-invokation branch February 1, 2023 20:46
@Dionysusnu

Dionysusnu commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Solves #166

FYI, if you replace "Solves" with fixes or closes, GitHub will automatically close the linked issue when a Pull Request is merged into the main branch.

For example: "closes #166"

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@krypt102

krypt102 commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

Solves #166

FYI, if you replace "Solves" with fixes or closes, GitHub will automatically close the linked issue when a Pull Request is merged into the main branch.

For example: "closes #166"

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Ohhhh, thank you! That's why it wasn't showing before 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready to work on Enhancements/changes ready to be made

Projects

Fusion 0.3
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow immediate invokation for Observer:onChange()

3 participants

@krypt102 @dphfox @Dionysusnu