Minor Changes, most notably singleton types#149
Closed
bobbybob2131 wants to merge 7 commits into
Closed
Conversation
{x} is ~1.5x faster than table.pack, which is a micro-optimisation but it is better to use as a standard across a whole library.
Dionysusnu
suggested changes
Apr 6, 2022
Owner
|
We use |
Merged
Owner
|
Closing in favour of a newer PR #215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singleton types were recently added (see https://devforum.roblox.com/t/luau-recap-march-2022/1738645 and https://github.com/Roblox/luau/blob/master/rfcs/syntax-singleton-types.md), this PR just updates Fusion to utilise them. All edits are based on existing comments. I also removed a completed (I think?) todo note.
Edit: Sorry for the close/reopen, I thought I needed to make a new PR to add the second commit but Github does it automatically.
Edit: Remove table.pack note