Merged
Conversation
…ework code and documentation
Contributor
|
👍 Great work here @fgrehm |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This paves the way for packaging the framework for distribution with RubyGems / NPM / Bower by making a clear distinction of what is framework and what is documentation. It also removes the dependency on using middleman to prepare the final precompiled CSS for a release
TODO
Figure out if there is a better way for serving fonts / css files from outside middleman source dir that does not involve using a symlink (as of the first commit on this PR we have a warning in place because of that, but the website works)Couldn't find a better way to handle that and was able to remove the warning after I gemified the projectvital:buildrake task that builds the assets and does not rely on middleman for building