fix(hooks): call a11y status message on items change#1073
Merged
silviuaavram merged 6 commits intomasterfrom Jun 12, 2020
Merged
fix(hooks): call a11y status message on items change#1073silviuaavram merged 6 commits intomasterfrom
silviuaavram merged 6 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1319 1319
Branches 241 241
=========================================
Hits 1319 1319
Continue to review full report at Codecov.
|
Collaborator
Author
|
🎉 This PR is included in version 5.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Calling updateA11yStatus when
itemsprop change.Why:
To reflect, for instance, the number of results change when combobox filters the items by input value
Closes #1076.
How:
Add
itemsto the list of dependencies that trigger the effect with the status update.Checklist: