fix: update element ids when related props change#1656
Merged
silviuaavram merged 1 commit intodownshift-js:masterfrom Dec 2, 2025
Merged
fix: update element ids when related props change#1656silviuaavram merged 1 commit intodownshift-js:masterfrom
silviuaavram merged 1 commit intodownshift-js:masterfrom
Conversation
Contributor
Author
|
@silviuaavram - just pinging you for review whenever you get the time, sorry this took so long to put up 😅 |
silviuaavram
approved these changes
Oct 9, 2025
Collaborator
|
@juzerzarif could you rebase and push again, please? not sure why CI does not kick in |
We used to memoize the element id props on the first render and then use those throughout the lifecycle of the component. This could cause ids in the markup to be out of sync from the ids provided via props. This change updates the internal element id getter references whenever any id related props change to propagate those props changes to the markup.
7884d56 to
0d4f48f
Compare
Contributor
Author
@silviuaavram rebased. Looks like the workflow needs maintainer approval to run. |
|
🎉 This PR is included in version 9.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fixes #1651.
Elements'
idattributes in the markup stay in sync with the props when the props change during the lifecycle of the hook.Why:
We used to memoize the element id props on the first render and then use those throughout the lifecycle of the component. This could cause ids in the markup to be out of sync from the ids provided via props.
How:
This change updates the internal element id getter references whenever any id related props change to propagate those props changes to the markup.
Checklist: