fix(highlightedIndex): do not highlight disabled items#1601
Merged
silviuaavram merged 1 commit intomasterfrom May 17, 2024
Merged
fix(highlightedIndex): do not highlight disabled items#1601silviuaavram merged 1 commit intomasterfrom
silviuaavram merged 1 commit intomasterfrom
Conversation
1f53403 to
5ffbd15
Compare
|
🎉 This PR is included in version 9.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix all the scenarios when an item can be highlighted even if it's disabled.
Why:
Fixes #1599.
How:
Check if item is disabled when setting the highlightedIndex via reset, imperative set, as well as user actions such as open on click / arrow down and up.
Checklist: