fix(a11yStatus): pass correct dependency array#1586
Merged
silviuaavram merged 1 commit intomasterfrom Mar 29, 2024
Merged
Conversation
5 tasks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1721 1721
Branches 515 515
=========================================
Hits 1721 1721 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix the dependency array in the useEffect that triggers the a11y status change.
Why:
The parameter we passed to updateA11yStatus was an array, and we wrapped that array into another array which we passed to useEffect. Resulted in a broken behaviour.
How:
Pass the dependency array directly to the useEffect hook.
Checklist: