Merged
Conversation
This was referenced Dec 6, 2021
tkapin
approved these changes
Dec 6, 2021
rolfbjarne
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared Xamarin code allowed for a short window in-between the app being installed and launched but not having connected over TCP to XHarness' listener.
We add a more granular code that will describe this case so that we don't need to return
TIMED_OUTwhen--launch-timeoutoccurs sinceTIMED_OUTmeans that tests themselves are running too long. This new launch timeout is then categorized as infra failure rather than user's fault.Resolves #785