[Xcode12.5]Merge main#486
Merged
mandel-macaque merged 12 commits intodotnet:xcode/12.5from Feb 26, 2021
Merged
Conversation
- I compared what we send to and what we receive from the TestRunner EntryPoint and noticed quite a bit of unused options. These are remnants of the Xamarin code with which we don't share the EntryPoint anymore - We are passing arguments both via env variables and arguments so we will only pass the env vars now - There was a bug in the definition of the `class` argument and it wasn't parsed properly - Another thing I fixed are the "extra" arguments - I don't they they were working until know because we prepend them with a `-app-arg:` prefix which is only recognized in the Xamarin's mono Main
Side effects of other work, related to dotnet#358
* fail faster when cannot find any devices/emulators * Apply suggestions from code review Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com> Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
- Adds support for the `apple test -t=maccatalyst` command (resolves dotnet#435) - Getting system logs for the process is not working at the moment (dotnet#459) - The `apple run` command cannot detect exit code yet (dotnet#462)
* allow to skip device-id for android install/run/uninstall if device can be choosed unambiguously * Update src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com> * addressed review feedback Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
…225.5 (dotnet#482) [main] Update dependencies from dotnet/arcade
dalexsoto
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.