Fix for Bug 1493635: MenuItems with IsCheckable and StaysOpenOnClick set to true do not announce to Narrator when IsChecked is changed#6706
Merged
anjaligupta-dev merged 5 commits intomainfrom Jul 1, 2022
Conversation
added 2 commits
June 21, 2022 18:50
…set to true do not announce to Narrator when IsChecked is changed
…set to true do not announce to Narrator when IsChecked is changed
lindexi
reviewed
Jun 22, 2022
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Controls/MenuItem.cs
Show resolved
Hide resolved
…set to true do not announce to Narrator when IsChecked is changed
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...tNet.Wpf/src/PresentationFramework/System/Windows/Automation/Peers/MenuItemAutomationPeer.cs
Outdated
Show resolved
Hide resolved
…set to true do not announce to Narrator when IsChecked is changed
singhashish-wpf
approved these changes
Jun 27, 2022
SamBent
reviewed
Jun 28, 2022
...tNet.Wpf/src/PresentationFramework/System/Windows/Automation/Peers/MenuItemAutomationPeer.cs
Show resolved
Hide resolved
dipeshmsft
approved these changes
Jun 29, 2022
…set to true do not announce to Narrator when IsChecked is changed
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5237
Description
Provided a fix for the problem when windows Narrator was not announcing anything when IsChecked is changed (e.g. the item is clicked on or the user types "Enter" while focusing it).
Customer Impact
Fixes a regression.
Regression
Yes
Testing
NA
Risk
Low
Microsoft Reviewers: Open in CodeFlow