Stop boxing in Visual.SetDpiScaleVisualFlags#6309
Merged
dipeshmsft merged 1 commit intodotnet:mainfrom May 5, 2022
Merged
Conversation
This uses DpiScale.Equals(DpiScale), but there's no such strongly-typed overload, so it falls back to using ValueType.Equals(object), which not only boxes the DpiScale but also both doubles that end up being compared. This just adds an internal Equals method to DpiScale to bind to that Equals instead; ideally in the future DpiScale would implement `IEquatable<T>` and this `Equals` would be made public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uses DpiScale.Equals(DpiScale), but there's no such strongly-typed overload, so it falls back to using ValueType.Equals(object), which not only boxes the DpiScale but also both doubles that end up being compared. This just adds an internal Equals method to DpiScale to bind to that Equals instead; ideally in the future DpiScale would implement
IEquatable<T>and thisEqualswould be made public.Customer Impact
Unnecessary allocation / overhead
Regression
No
Testing
CI
Risk
Minimal