Skip to content

Optimize the code of OSVersionHelper#6252

Open
lindexi wants to merge 1 commit intodotnet:mainfrom
dotnet-campus:t/lindexi/OSVersionHelper
Open

Optimize the code of OSVersionHelper#6252
lindexi wants to merge 1 commit intodotnet:mainfrom
dotnet-campus:t/lindexi/OSVersionHelper

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Mar 13, 2022

Description

We can not run the WPF application in the system which version lower than win7. And it will return fast without call the RtlVerifyVersionInfo method.

Customer Impact

Improve performance?

Regression

None.

Testing

Just CI.

Risk

Low.

We can not run the WPF application in the system which version lower than win7.
@lindexi lindexi requested a review from a team as a code owner March 13, 2022 02:57
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Mar 13, 2022
@ghost ghost requested review from SamBent, dipeshmsft and singhashish-wpf March 13, 2022 02:57
@ghost ghost added the Community Contribution A label for all community Contributions label Mar 13, 2022
@dipeshmsft dipeshmsft self-assigned this May 5, 2022
@ghost ghost assigned lindexi May 5, 2022
@dipeshmsft dipeshmsft removed their assignment Feb 5, 2023
@dipeshmsft
Copy link
Member

@lindexi Do we have a benchmark for this?

@lindexi
Copy link
Member Author

lindexi commented Feb 16, 2023

@dipeshmsft Sorry, I do not know how to test it. Can you tell me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants