Ensure that markup compilation is run for all design time builds#2004
Merged
wtgodbe merged 1 commit intodotnet:release/3.1from Oct 5, 2019
Merged
Conversation
Member
Author
|
Marking as |
Member
|
Approved by shiproom/tactics/Steve, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1895
Fixes #1915
/cc @debonte, @davidwengier
Description
In SDK-style projects the project system will combine design time builds together to improve performance, but depending on timing, this can cause issues. If something like the designer asks for output groups, then the build for that could be combined with the build that produces the intellisense file, but getting output groups sets
BuildingProjecttotrue, which in turn prevents WPF's markup-compilation from running.This change works around the issue by allowing the intellisense files to generate irrespective of the value of
BuildingProject, as long we're doing a design time build.Customer Impact
Developers encountering this problem see the following error:
This is usually persistent and doesn't go away upon rebuilds. It can sometimes be overcome by persistently cleaning the project, deleting intermediate files etc., and rebuilding.
We have also been hearing several reports of this on .NET core via //vsfeedback.
Regression
Not a regression. This problem exists in .NET Framework also, but now we understand what's going on and have a fix for this.
Risk
Low risk.
The fix is very simple, safe and easy to test. It has been in master/.NET 5 for a few weeks now.