-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Dev guide fix #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev guide fix #1028
Conversation
|
Can you also add the fixes described here: https://github.com/dotnet/coreclr/issues/25279#issuecomment-504156727 I think that should fix all the trouble we've been having. I was about to do this myself but you beat me to getting a PR out :) |
|
@stevenbrix Sure I can do that, but it sounded like you weren't completely sure that was the issue? |
|
Oh no, that's definitely the fix. I'm not sure if something changed that caused the old method to no longer work, but the issue was that the local assemblies weren't being added to the deps.json. I looked into some binlogs and figured out which target was responsible for writing them and it makes sense why it doesn't work now, just not why it did before :) |
|
Should we add a comment that you need preview 7? I cannot get this working on preview 6 due to the security access thing. I wrote up a little blog on how to build yourself here: https://xaml.dev/post/2019/06/21/Compiling-and-debugging-WPF |
|
One more thing I'm finding: PresentationCore.dll is not copied over (or it's overwritten by the installed version), so I had to add this silly post-build step to be able to debug that one: |
Yeah, preview 7 is definitely needed. Although I'm not sure a comment about a specific version number is the right approach, unless there was a sure way to keep it up-to-date. The general philosophy should probably be "if something isn't working right, first check the sdk version you have installed and what version of |
What is the assembly version of PresentationCore? It sounds like it isn't overriding the one contained in the |
|
Ok, so I opened up PresentationCore.dll in ILspy and the Assembly Version info looks correct (or at least the same as other WPF assemblies). I'm going to file an issue, since that goes beyond updating this dev-guide. thanks for the updates! Opened #1061 to track this |
PropertyGroup tag wasn't closing and FrameworkReference must be inside an ItemGroup