Skip to content

Added unit tests for "AccessibleObject.FragmentNavigate" method in PropertyGridAccessibleObject class#8206

Merged
dreddy-work merged 1 commit intodotnet:mainfrom
v-elnovikova:Issue_6094_Adding_Tests_For_PropertyGrid
Nov 23, 2022
Merged

Added unit tests for "AccessibleObject.FragmentNavigate" method in PropertyGridAccessibleObject class#8206
dreddy-work merged 1 commit intodotnet:mainfrom
v-elnovikova:Issue_6094_Adding_Tests_For_PropertyGrid

Conversation

@v-elnovikova
Copy link
Contributor

@v-elnovikova v-elnovikova commented Nov 16, 2022 •
edited by ghost
Loading

Part of #6094

Proposed changes

  • Add missing unit tests to check the method behavior in PropertyGridAccessibleObject class

Test environment(s)

  • .NET 7.0.0-rc.2.22472.3
  • Windows 11
Microsoft Reviewers: Open in CodeFlow

@v-elnovikova v-elnovikova requested a review from a team as a code owner November 16, 2022 15:24
@ghost ghost assigned v-elnovikova Nov 16, 2022
@v-elnovikova v-elnovikova added the waiting-review This item is waiting on review by one or more members of team label Nov 16, 2022
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Nov 16, 2022
View reviewed changes
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Nov 16, 2022
@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Nov 17, 2022

System.Windows.Forms.Tests.CursorConverterTests.CursorConverter_GetStandardValues_Invoke_ReturnsExpected


Assert.Contains() Failure\r\nNot found: [Cursor: System.Windows.Forms.Cursor]\r\nIn value:  Cursor[] [[Cursor: AppStarting], [Cursor: Arrow], [Cursor: Cross], [Cursor: Default], [Cursor: IBeam], ...]

Stack trace
   at System.Windows.Forms.Tests.CursorConverterTests.CursorConverter_GetStandardValues_Invoke_ReturnsExpected() in /_/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/CursorConverterTests.cs:line 214
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

This was referenced Nov 17, 2022
Closed
Closed
@v-elnovikova v-elnovikova force-pushed the Issue_6094_Adding_Tests_For_PropertyGrid branch from 2bc0a96 to ad39683 Compare November 22, 2022 14:08
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Nov 22, 2022
@dmitrii-drobotov dmitrii-drobotov added the waiting-author-feedback The team requires more information from the author label Nov 22, 2022
@v-elnovikova v-elnovikova force-pushed the Issue_6094_Adding_Tests_For_PropertyGrid branch from ad39683 to 409f6f0 Compare November 23, 2022 11:41
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Nov 23, 2022
dmitrii-drobotov
dmitrii-drobotov approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitrii-drobotov
Copy link
Contributor

dmitrii-drobotov commented Nov 23, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 23, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@dreddy-work dreddy-work merged commit aca04d9 into dotnet:main Nov 23, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Nov 23, 2022
@dmitrii-drobotov dmitrii-drobotov mentioned this pull request Nov 24, 2022
Closed
28 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
@v-elnovikova v-elnovikova deleted the Issue_6094_Adding_Tests_For_PropertyGrid branch May 25, 2023 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NikitaSemenovAkvelon NikitaSemenovAkvelon Awaiting requested review from NikitaSemenovAkvelon

@dkazennov dkazennov Awaiting requested review from dkazennov

2 more reviewers

@dmitrii-drobotov dmitrii-drobotov dmitrii-drobotov approved these changes

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@v-elnovikova v-elnovikova

Labels

None yet

Projects

None yet

Milestone

8.0 Preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@v-elnovikova @Tanya-Solyanik @dmitrii-drobotov @dreddy-work