Skip to content

Convert AxHost IPersistX Interface to Cswin32#8052

Merged
lonitra merged 8 commits intodotnet:mainfrom
lonitra:streams
Oct 28, 2022
Merged

Convert AxHost IPersistX Interface to Cswin32#8052
lonitra merged 8 commits intodotnet:mainfrom
lonitra:streams

Conversation

@lonitra
Copy link
Member

@lonitra lonitra commented Oct 27, 2022 •
edited
Loading

  • Converted rest of AxHost interfaces (IPersistX) to cswin32 version, which prompted for the conversion of other relating interfaces: IStream,IStorage,IPropertyBag,IPicture,IPictureDisp
  • Added helpers to ComHelpers.cs to get IDispatch property and get scoped pointers
  • Convert IStream vtable to the new pattern
  • Remove PictureWrapper
  • Create real mocks in Com2PictureConverterTests since IPicture can no longer be mocked using moq
Microsoft Reviewers: Open in CodeFlow

@lonitra lonitra requested a review from a team as a code owner October 27, 2022 16:08
@ghost ghost assigned lonitra Oct 27, 2022
@runfoapp runfoapp bot mentioned this pull request Oct 27, 2022
Closed
JeremyKuhne
JeremyKuhne requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. I'll connect with you to see if we can remove the PictureWrapper.

@ghost ghost added the waiting-author-feedback The team requires more information from the author label Oct 27, 2022
@lonitra lonitra requested a review from JeremyKuhne October 27, 2022 20:00
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Oct 27, 2022
@runfoapp runfoapp bot mentioned this pull request Oct 27, 2022
Closed
JeremyKuhne
JeremyKuhne previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@lonitra lonitra enabled auto-merge (squash) October 28, 2022 01:18
@lonitra lonitra merged commit 3d7a6fd into dotnet:main Oct 28, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Oct 28, 2022
@lonitra lonitra deleted the streams branch October 28, 2022 15:47
@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

+1 more reviewer

@RussKie RussKie RussKie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lonitra lonitra

Labels

None yet

Projects

None yet

Milestone

8.0 Preview1

Development

Successfully merging this pull request may close these issues.

3 participants

@lonitra @RussKie @JeremyKuhne