Enable nullability in ToolStripComboBoxControl#8050
Merged
dreddy-work merged 1 commit intodotnet:mainfrom Oct 28, 2022
Merged
Conversation
dreddy-work
approved these changes
Oct 27, 2022
RussKie
approved these changes
Oct 27, 2022
dreddy-work
reviewed
Oct 27, 2022
| { | ||
| ToolStripComboBoxControl? toolStripComboBox = comboBox as ToolStripComboBoxControl; | ||
| if (toolStripComboBox is null || !(toolStripComboBox.Owner.Renderer is ToolStripProfessionalRenderer)) | ||
| if (toolStripComboBox is null || toolStripComboBox.Owner?.Renderer is not ToolStripProfessionalRenderer) |
Member
There was a problem hiding this comment.
is this avoiding null reference exception? or we were just missing the check earlier?
Contributor
Author
There was a problem hiding this comment.
Because Owner can be null, there is a warning now, so I added the ? operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow