Skip to content

Convert AxHost Interfaces to Cswin32#8020

Merged
lonitra merged 5 commits intodotnet:mainfrom
lonitra:axhostchange
Oct 26, 2022
Merged

Convert AxHost Interfaces to Cswin32#8020
lonitra merged 5 commits intodotnet:mainfrom
lonitra:axhostchange

Conversation

@lonitra
Copy link
Member

@lonitra lonitra commented Oct 24, 2022

  • Removes our definition of IOleInPlaceActiveObject, IOleInPlaceObject, IOleInPlaceObjectWindowless,
    IOleWindow,IOleClientSite,IOleContainer,IOleObject,IPerPropertyBrowsing and use Cswin32 interfaces
  • Add helper functions in ComHelpers.cs to reduce redundant code revolving around querying for interface of an object
  • Axhost interfaces revolving around streams/storage will be a follow up.
Microsoft Reviewers: Open in CodeFlow

@lonitra lonitra requested a review from a team as a code owner October 24, 2022 20:48
@ghost ghost assigned lonitra Oct 24, 2022
JeremyKuhne
JeremyKuhne previously approved these changes Oct 24, 2022
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, otherwise looks good!

Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lonitra lonitra merged commit 1a192b5 into dotnet:main Oct 26, 2022
@lonitra lonitra deleted the axhostchange branch October 26, 2022 21:51
@ghost ghost added this to the 8.0 Preview1 milestone Oct 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants