Skip to content

Added unit tests for "AccessibleObject.FragmentNavigate" method in DataGridViewCell-related classes#7930

Merged
RussKie merged 3 commits intodotnet:mainfrom
v-elnovikova:Issue_6094_Adding_Tests_For_DataGridViewCell
Oct 27, 2022
Merged

Added unit tests for "AccessibleObject.FragmentNavigate" method in DataGridViewCell-related classes#7930
RussKie merged 3 commits intodotnet:mainfrom
v-elnovikova:Issue_6094_Adding_Tests_For_DataGridViewCell

Conversation

@v-elnovikova
Copy link
Contributor

@v-elnovikova v-elnovikova commented Oct 12, 2022 •
edited by RussKie
Loading

Fixes #6094

Proposed changes

  • Add missing unit tests to check the method behavior in base class and derived classes

Test environment(s)

  • .NET 7.0.0-rc.1.22426.10
  • Windows 11
Microsoft Reviewers: Open in CodeFlow

@v-elnovikova v-elnovikova requested a review from a team as a code owner October 12, 2022 09:53
@ghost ghost assigned v-elnovikova Oct 12, 2022
@dnfadmin
Copy link

dnfadmin commented Oct 12, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@v-elnovikova v-elnovikova changed the title Added unit tests for "AccessibleObject.FragmentNavigate" method in DataGridViewCellAccessibleObject, DataGridViewRowHeaderCellAccessibleObject, DataGridViewTopLeftHeaderCellAccessibleObject Added unit tests for "AccessibleObject.FragmentNavigate" method in DataGridViewCell-related classes Oct 12, 2022
@v-elnovikova
Added tests for FragmentNavigate method in DataGridViewCellAccessible…
feeeeea 
…Object, DataGridViewRowHeaderCellAccessibleObject, DataGridViewTopLeftHeaderCellAccessibleObject
@v-elnovikova v-elnovikova force-pushed the Issue_6094_Adding_Tests_For_DataGridViewCell branch from 329d924 to feeeeea Compare October 12, 2022 10:33
dmitrii-drobotov
dmitrii-drobotov previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dmitrii-drobotov dmitrii-drobotov added the waiting-review This item is waiting on review by one or more members of team label Oct 12, 2022
RussKie
RussKie reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RussKie RussKie added waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team and removed waiting-review This item is waiting on review by one or more members of team labels Oct 13, 2022
Tanya-Solyanik
Tanya-Solyanik reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great selection of hierarchies to test! Is it possible to change tests for cells to Theories with one path that creates handle and another does not?

@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Oct 24, 2022
@v-elnovikova v-elnovikova added the waiting-review This item is waiting on review by one or more members of team label Oct 24, 2022
Tanya-Solyanik
Tanya-Solyanik reviewed Oct 24, 2022
View reviewed changes
...Forms/tests/UnitTests/System/Windows/Forms/DataGridViewRowHeaderCellAccessibleObjectTests.cs Outdated
if (!createControl)
{
Assert.False(control.IsHandleCreated);
}
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
Assert.Equal(createControl, control.IsHandleCreated);

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment applies in multiple spots.

Copy link
Contributor Author

@v-elnovikova v-elnovikova Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in all spots.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Oct 24, 2022
RussKie
RussKie reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 modulo Tanya's comments

@v-elnovikova v-elnovikova force-pushed the Issue_6094_Adding_Tests_For_DataGridViewCell branch from f2b5497 to 47addfe Compare October 26, 2022 10:38
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Oct 26, 2022
@v-elnovikova v-elnovikova added the waiting-review This item is waiting on review by one or more members of team label Oct 26, 2022
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Oct 27, 2022
@RussKie RussKie merged commit 4a8221b into dotnet:main Oct 27, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Oct 27, 2022
@RussKie
Copy link
Contributor

RussKie commented Oct 27, 2022

Thank you

@RussKie RussKie mentioned this pull request Oct 27, 2022
Closed
28 tasks
@v-elnovikova v-elnovikova deleted the Issue_6094_Adding_Tests_For_DataGridViewCell branch October 31, 2022 18:29
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NikitaSemenovAkvelon NikitaSemenovAkvelon Awaiting requested review from NikitaSemenovAkvelon

@dkazennov dkazennov Awaiting requested review from dkazennov

3 more reviewers

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik left review comments

@RussKie RussKie RussKie approved these changes

@dmitrii-drobotov dmitrii-drobotov dmitrii-drobotov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-elnovikova v-elnovikova

Labels

None yet

Projects

None yet

Milestone

8.0 Preview1

Development

Successfully merging this pull request may close these issues.

Add missing unit tests for "AccessibleObject.FragmentNavigate" method

5 participants

@v-elnovikova @dnfadmin @RussKie @Tanya-Solyanik @dmitrii-drobotov