Skip to content

added support of C#11 to templates#7645

Merged
dreddy-work merged 1 commit intodotnet:release/7.0from
vlada-shubina:template-fix
Aug 24, 2022
Merged

added support of C#11 to templates#7645
dreddy-work merged 1 commit intodotnet:release/7.0from
vlada-shubina:template-fix

Conversation

@vlada-shubina
Copy link
Copy Markdown
Member

@vlada-shubina vlada-shubina commented Aug 23, 2022

Problem

In the templates, the generators which determine minimum language version in use were not considering C#11.
Fixed regex to support it.

Customer impact

Without this fix, using C# 11.0 via --langVersion option will result in old style template (no top level statements, file scoped namespaces, implicit usings)

Testing

Automated

Risk

Very low.
Language version option is only available in CLI and not exposed in Visual Studio.

Microsoft Reviewers: Open in CodeFlow

@vlada-shubina vlada-shubina requested a review from a team as a code owner August 23, 2022 08:50
@ghost ghost assigned vlada-shubina Aug 23, 2022
@vlada-shubina
Copy link
Copy Markdown
Member Author

@merriemcgaw @RussKie please help to review and ensure it gets to 7.0, thank you.

do you have any automation tests to cover this change?

cc: @baronfel

@baronfel
Copy link
Copy Markdown
Member

The SDK version of this same fix was just approved for merge, so this should be merge-able as well for 7.0: dotnet/sdk#27361

@dreddy-work
Copy link
Copy Markdown
Member

The SDK version of this same fix was just approved for merge, so this should be merge-able as well for 7.0: dotnet/sdk#27361

@baronfel , I missed part of the discussion in tactics. Is that sdk branch pointing RC1 or RC2?

@baronfel
Copy link
Copy Markdown
Member

It's on the 'base' 7.0.1xx branch, which right now is RC2.

@dreddy-work
Copy link
Copy Markdown
Member

/backport to main

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to main: https://github.com/dotnet/winforms/actions/runs/2913582126

@RussKie
Copy link
Copy Markdown
Contributor

RussKie commented Aug 24, 2022

do you have any automation tests to cover this change?

Unfortunately we don't. Still waiting for dotnet/templating#3868 ;)

@dreddy-work dreddy-work merged commit 53a4fa0 into dotnet:release/7.0 Aug 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants