Fix KeyNotFoundException in KeysConverter.ConvertFrom#7632
Merged
dreddy-work merged 1 commit intodotnet:mainfrom Aug 22, 2022
Merged
Fix KeyNotFoundException in KeysConverter.ConvertFrom#7632dreddy-work merged 1 commit intodotnet:mainfrom
dreddy-work merged 1 commit intodotnet:mainfrom
Conversation
RussKie
approved these changes
Aug 22, 2022
Member
|
@RussKie this is not RC2 branch. Please create PR against release/7.0 (which is RC2 now). |
Member
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/winforms/actions/runs/2906129796 |
dreddy-work
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7610
Proposed changes
TryGetValueandEnum.Parseinstead of Dictionary indexer. The changes resemble the state of the code before Enable nullability in KeysConverter #6448.Customer Impact
new KeysConverter().ConvertFrom("Ctrl + N")throws KeyNotFoundException.Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow