Adding supports of UIA provider for ToolStripPanel#7459
Conversation
087a332 to
b30ec09
Compare
b30ec09 to
1cd81f9
Compare
|
@NikitaSemenovAkvelon - could you please describe your manual testing a bit? I wonder if you tested different layout within the toolstrip panel. Also consider adding your manual test to the |
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, but please describe your manual testing a bit.
...s/tests/UnitTests/System/Windows/Forms/ToolStripPanel.ToolStripPanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...s/tests/UnitTests/System/Windows/Forms/ToolStripPanel.ToolStripPanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...stem.Windows.Forms/src/System/Windows/Forms/ToolStripPanel.ToolStripPanelAccessibleObject.cs
Show resolved
Hide resolved
1cd81f9 to
83f189d
Compare
For testing I used a form from https://docs.microsoft.com/en-us/dotNet/api/system.windows.forms.toolstrippanel?view=netframework-3.5. If it necessary I'll add it to |
I don't think it's necessary because this sample is easily accessible if we are to do more work with this control. WinformsControlsTest exists for our convenience, so that we can easily repeat our scenarios. |
| return role; | ||
| } | ||
|
|
||
| return AccessibleRole.Client; |
There was a problem hiding this comment.
nit: we are moving towards more concise code when possible, i.e.
return role == AccessibleRole.Default : AccessibleRole.Client ? role;
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, thank you!
|
Verified on latest .NET 7 build .NET 7.0.100-rc.1.22378.6, issue is fixed, screenshot as below: |
Partially implements #3421
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow