Implementing uia provider support for DTP control#6620
Merged
Tanya-Solyanik merged 1 commit intodotnet:mainfrom Feb 21, 2022
Merged
Implementing uia provider support for DTP control#6620Tanya-Solyanik merged 1 commit intodotnet:mainfrom
Tanya-Solyanik merged 1 commit intodotnet:mainfrom
Conversation
RussKie
previously approved these changes
Feb 4, 2022
dreddy-work
reviewed
Feb 4, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DateTimePicker.cs
Outdated
Show resolved
Hide resolved
c09dbfa to
c43aae6
Compare
RussKie
reviewed
Feb 8, 2022
...m.Windows.Forms/tests/UnitTests/System/Windows/Forms/Control.ControlAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/DateTimePicker.cs
Outdated
Show resolved
Hide resolved
7181a58 to
e01af3e
Compare
Contributor
|
@Olina-Zhang - could you please test this change? |
e01af3e to
ad15840
Compare
Contributor
Author
|
Fixed 2 found issues here. Sent it to retest. |
ad15840 to
a98c648
Compare
Tanya-Solyanik
previously approved these changes
Feb 17, 2022
Contributor
|
Completed testing with no new issue found now. |
a98c648 to
c2975ec
Compare
c2975ec to
11a1e37
Compare
dreddy-work
previously approved these changes
Feb 18, 2022
Member
|
When you are working fixing found issues like this, it would be nice if you push the changes as separate commit here, instead of force pushing, to make the review easy. We can always squash commits when merging. |
Member
|
@DmitryGorokhov , this needs rebase. |
Fixed SupportsUiaPrividers method to return true and fixed Narrator announcing.
11a1e37 to
832d789
Compare
Tanya-Solyanik
approved these changes
Feb 21, 2022
Contributor
|
Verified with .NET SDK 7.0.100-preview.3.22153.11 build, this issue is fixed. |
|
Hi @Philip-Wang01, it looks like you just commented on a closed PR. The team will most probably miss it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #3421
Proposed changes
SupportsUiaProvidersproperty ofDateTimePickerclass.DateTimePickerAccessibleObject, added unit tests.AccessKeyfor dtp inControlAccessibleObjectTests.Customer Impact
DateTimePickercontrol accessibility.Regression?
Risk
Screenshots
Changes in accessibility tools.
Accessibility Insights
Before
After
Narrator & Buddy
The behavior in Narrator was restored after the fix. Seems was resolved problem described in issue #5487.
Calendar issue
The Narrator doesn't work with dtp calendar. Seems, it is native control problem, because the Narrator doesn't work with dtp in MFC app at all. You can see it on following gif below.
I attach the test MFC app with dtp: MFCApplication.zip
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow