Adding UIA support for PrintPreviewControl by Danil-Andrianov · Pull Request #6600 · dotnet/winforms

Danil-Andrianov · 2022-02-02T06:38:00Z

Partially implements #3421

Proposed changes

Updated "SupportsUiaProviders" flag.
Added and implemented printPreviewControlaccessible object
Added unit tests

Customer Impact

Before update:
After update:
Provider was changed.

Regression?

No

Risk

Minimal

Test methodology

Unit tests
CTI team

Accessibility testing

Narrator
Inspect
Accessibility Insights

Test environment(s)

Microsoft Windows [Version 10.0.22000.318]
.NET Core SDK: 7.0.0-alpha.1.21562.1

Microsoft Reviewers: Open in CodeFlow

dreddy-work · 2022-02-08T00:33:39Z

...itTests/System/Windows/Forms/PrintPreviewControl.PrintPreviewControlAccessibleObjectTests.cs

+        [WinFormsFact]
+        public void PrintPreviewControlAccessibleObject_GetPropertyValue_Focused_ReturnsExpected()
+        {
+            Form form = new();


dreddy-work

RLGTM. @Tanya-Solyanik , when you get a chance, can you take a final look here?

...ws.Forms/src/System/Windows/Forms/PrintPreviewControl.PrintPreviewControlAccessibleObject.cs

RussKie · 2022-02-08T02:25:40Z

...System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/WinformsControlsTest.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">


This is noise, please revert

Tanya-Solyanik

Looks good, @Olina-Zhang - could you please test this change

IDEExperienceTestSolution · 2022-02-09T08:43:48Z

Tested the private binaries that built by ourselves for this PR based on latest .Net 7.0 using Accessiblity Tools: Inspect, Accessiblity Insight, and Narrator. The providerDescription information is updated and no new issue found:

In addition, all the migrated automation cases are passed.

Tanya-Solyanik · 2022-02-17T00:21:46Z

new unrelated failure:

Assert.Equal() Failure\r\nExpected: 1\r\nActual:   MemoryStream { CanRead = True, CanSeek = True, CanTimeout = False, CanWrite = True, Capacity = 70, ... }


Stack trace
   at System.Windows.Forms.Tests.ClipboardTests.Clipboard_SetDataObject_InvokeObjectBoolNotIComDataObject_GetReturnsExpected(Object data, Boolean copy) in /_/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ClipboardTests.cs:line 279

azure-pipelines · 2022-02-17T00:24:59Z

Azure Pipelines successfully started running 2 pipeline(s).

Tanya-Solyanik · 2022-02-17T00:25:11Z

/azp run

azure-pipelines · 2022-02-17T00:25:27Z

Azure Pipelines successfully started running 2 pipeline(s).

vladimir-krestov

Should be carefully tested

vladimir-krestov · 2022-02-17T10:06:36Z

...itTests/System/Windows/Forms/PrintPreviewControl.PrintPreviewControlAccessibleObjectTests.cs

+            using Form form = new();
+            using var control = new PrintPreviewControl();


Please use one style for your tests:

Suggested change

using Form form = new();

using var control = new PrintPreviewControl();

using Form form = new();

using PrintPreviewControl control = new();

vladimir-krestov · 2022-02-17T10:19:48Z

...itTests/System/Windows/Forms/PrintPreviewControl.PrintPreviewControlAccessibleObjectTests.cs

+            using Form form = new();
+            using var control = new PrintPreviewControl();
+            form.Controls.Add(control);
+            form.Show();


Please consider the ability to test this case without creating a form. Because this test is already UI test

Unfortunately, in this case the focus can't be set without creating form.

Doesn't FocusActiveControlInternal work? Or something like that:
User32.SetFocus(new HandleRef(_activeControl, _activeControl.Handle));? (don't forget to CreateControl before)

The latter way works fine, thanks.

Tanya-Solyanik

Looks good, but please make sure the @vladimir-krestov signs off, seems like his comments are addressed

Tanya-Solyanik · 2022-02-18T21:42:19Z

/azp run

azure-pipelines · 2022-02-18T21:42:34Z

Azure Pipelines successfully started running 2 pipeline(s).

vladimir-krestov

Approved ✔️

Tanya-Solyanik

Looks good

Cassie-Li01 · 2022-03-04T06:47:15Z

Verified on 7.0.100-preview.3.22124.15, this is fixed.

ghost · 2022-03-04T06:47:18Z

Hi @Cassie-Li01, it looks like you just commented on a closed PR. The team will most probably miss it.
If you have a question - consider opening a new discussion thread. Alternatively, you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Danil-Andrianov requested a review from a team as a code owner February 2, 2022 06:38

ghost assigned Danil-Andrianov Feb 2, 2022

Danil-Andrianov marked this pull request as draft February 2, 2022 06:38

ghost added the draft draft PR label Feb 2, 2022

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch 2 times, most recently from c512d68 to e7717b4 Compare February 2, 2022 12:20

Danil-Andrianov removed the draft draft PR label Feb 2, 2022

Danil-Andrianov marked this pull request as ready for review February 2, 2022 12:21

Danil-Andrianov requested review from ArtemTatarinov, RussKie, SergeySmirnov-Akvelon, Tanya-Solyanik, WPMGPRoSToTeMa, dreddy-work and vladimir-krestov February 2, 2022 12:21

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch 3 times, most recently from 7ff876b to 1249f2e Compare February 3, 2022 06:15

dreddy-work reviewed Feb 8, 2022

View reviewed changes

dreddy-work previously approved these changes Feb 8, 2022

View reviewed changes

Tanya-Solyanik reviewed Feb 8, 2022

View reviewed changes

...ws.Forms/src/System/Windows/Forms/PrintPreviewControl.PrintPreviewControlAccessibleObject.cs Show resolved Hide resolved

RussKie reviewed Feb 8, 2022

View reviewed changes

Tanya-Solyanik previously approved these changes Feb 8, 2022

View reviewed changes

dreddy-work added waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) waiting-author-feedback The team requires more information from the author labels Feb 8, 2022

Danil-Andrianov dismissed stale reviews from Tanya-Solyanik and dreddy-work via 20cb633 February 8, 2022 20:03

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch from 1249f2e to 20cb633 Compare February 8, 2022 20:03

ghost removed the waiting-author-feedback The team requires more information from the author label Feb 8, 2022

Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Feb 9, 2022

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch from 20cb633 to cab44a4 Compare February 16, 2022 05:42

ghost removed the waiting-author-feedback The team requires more information from the author label Feb 16, 2022

Danil-Andrianov requested review from Tanya-Solyanik and dreddy-work February 16, 2022 05:45

vladimir-krestov reviewed Feb 17, 2022

View reviewed changes

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch 4 times, most recently from 6a9a4c8 to fcf25fa Compare February 18, 2022 09:33

Tanya-Solyanik previously approved these changes Feb 18, 2022

View reviewed changes

vladimir-krestov previously approved these changes Feb 19, 2022

View reviewed changes

Added UIA support for PrintPreviewControl

bc563b7

Danil-Andrianov dismissed stale reviews from vladimir-krestov and Tanya-Solyanik via bc563b7 February 19, 2022 09:03

Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForPrintPreviewControl branch from fcf25fa to bc563b7 Compare February 19, 2022 09:03

vladimir-krestov approved these changes Feb 19, 2022

View reviewed changes

Tanya-Solyanik approved these changes Feb 20, 2022

View reviewed changes

Tanya-Solyanik merged commit 10b647b into dotnet:main Feb 20, 2022

vladimir-krestov mentioned this pull request Feb 20, 2022

Re-enable skipped test: Clipboard_SetDataObject_InvokeObjectBoolNotIComDataObject_GetReturnsExpected` #6729

Closed

RussKie added this to the 7.0 Preview3 milestone Feb 22, 2022

ghost locked as resolved and limited conversation to collaborators Apr 3, 2022

		@@ -1,4 +1,4 @@
		<Project Sdk="Microsoft.NET.Sdk">
		<Project Sdk="Microsoft.NET.Sdk">

		using Form form = new();
		using var control = new PrintPreviewControl();

Conversation

Danil-Andrianov commented Feb 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

dreddy-work Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

dreddy-work left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RussKie Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

IDEExperienceTestSolution commented Feb 9, 2022

Uh oh!

Tanya-Solyanik commented Feb 17, 2022

Uh oh!

azure-pipelines bot commented Feb 17, 2022

Uh oh!

Tanya-Solyanik commented Feb 17, 2022

Uh oh!

azure-pipelines bot commented Feb 17, 2022

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

vladimir-krestov Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

vladimir-krestov Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

Danil-Andrianov Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

vladimir-krestov Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Danil-Andrianov Feb 18, 2022

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik commented Feb 18, 2022

Uh oh!

azure-pipelines bot commented Feb 18, 2022

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik left a comment

Choose a reason for hiding this comment

Uh oh!

Cassie-Li01 commented Mar 4, 2022

Uh oh!

ghost commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Danil-Andrianov commented Feb 2, 2022 •

edited

Loading

vladimir-krestov Feb 18, 2022 •

edited

Loading