Skip to content

Adding UIA support for toolStripContainer#6568

Merged
RussKie merged 1 commit intodotnet:mainfrom
Danil-Andrianov:Issue-3421_AddingUIASupportForToolStripContainer
Feb 12, 2022
Merged

Adding UIA support for toolStripContainer#6568
RussKie merged 1 commit intodotnet:mainfrom
Danil-Andrianov:Issue-3421_AddingUIASupportForToolStripContainer

Conversation

@Danil-Andrianov
Copy link
Contributor

@Danil-Andrianov Danil-Andrianov commented Jan 28, 2022 •
edited
Loading

Partially implements #3421

Proposed changes

  • Updated "SupportsUiaProviders" flag.
  • Added and implemented toolStripContainer accessible object
  • Added unit tests

Customer Impact

Before update:
InspectWithout
ToolStripContainer1

After update:
InspectWith
ToolStripContainer1

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
  • CTI team

Accessibility testing

  • Narrator
  • Inspect
  • Accessibility Insights

Test environment(s)

  • Microsoft Windows [Version 10.0.22000.318]
  • .NET Core SDK: 7.0.0-alpha.1.21562.1
Microsoft Reviewers: Open in CodeFlow

@Danil-Andrianov Danil-Andrianov requested a review from a team as a code owner January 28, 2022 10:04
@ghost ghost assigned Danil-Andrianov Jan 28, 2022
@Danil-Andrianov Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForToolStripContainer branch from e2fcb01 to 64ab5e5 Compare January 31, 2022 07:34
@vladimir-krestov vladimir-krestov mentioned this pull request Jan 31, 2022
Closed
70 tasks
@Danil-Andrianov Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForToolStripContainer branch from 64ab5e5 to c50eb44 Compare January 31, 2022 08:43
vladimir-krestov
vladimir-krestov reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@vladimir-krestov vladimir-krestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it works

@Danil-Andrianov Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForToolStripContainer branch 2 times, most recently from 031f779 to 49fc605 Compare February 1, 2022 11:26
dreddy-work
dreddy-work previously approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SergeySmirnov-Akvelon
SergeySmirnov-Akvelon reviewed Feb 2, 2022
View reviewed changes
@SergeySmirnov-Akvelon
Copy link
Contributor

SergeySmirnov-Akvelon commented Feb 2, 2022

LGTM. Please take a look at some minor points.

@Danil-Andrianov Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForToolStripContainer branch 2 times, most recently from 679c004 to 3ceacca Compare February 3, 2022 05:21
@Danil-Andrianov Danil-Andrianov force-pushed the Issue-3421_AddingUIASupportForToolStripContainer branch from 3ceacca to 5d3d98c Compare February 3, 2022 06:16
@dreddy-work dreddy-work added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Feb 10, 2022
@RussKie RussKie merged commit b56a086 into dotnet:main Feb 12, 2022
@ghost ghost added this to the 7.0 Preview2 milestone Feb 12, 2022
@Cassie-Li01
Copy link

Cassie-Li01 commented Feb 25, 2022

Verified with .NET SDK 7.0.100-preview.3.22124.15 build, this issue is fixed
image
image

@ghost
Copy link

ghost commented Feb 25, 2022

Hi @Cassie-Li01, it looks like you just commented on a closed PR. The team will most probably miss it.
If you have a question - consider opening a new discussion thread. Alternatively, you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@John-Qiao
Copy link
Contributor

John-Qiao commented Mar 7, 2022

Verified with .NET SDK 7.0.100-preview.2.22152.5 build, this issue is fixed as same as above test result.

@ghost
Copy link

ghost commented Mar 7, 2022

Hi @John-Qiao, it looks like you just commented on a closed PR. The team will most probably miss it.
If you have a question - consider opening a new discussion thread. Alternatively, you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tanya-Solyanik Tanya-Solyanik Awaiting requested review from Tanya-Solyanik

@ArtemTatarinov ArtemTatarinov Awaiting requested review from ArtemTatarinov

@WPMGPRoSToTeMa WPMGPRoSToTeMa Awaiting requested review from WPMGPRoSToTeMa

@lisoenot lisoenot Awaiting requested review from lisoenot

@vladimir-krestov vladimir-krestov Awaiting requested review from vladimir-krestov

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon Awaiting requested review from SergeySmirnov-Akvelon

2 more reviewers

@RussKie RussKie RussKie approved these changes

@dreddy-work dreddy-work dreddy-work approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Danil-Andrianov Danil-Andrianov

Labels

ready-to-merge PRs that are ready to merge but worth notifying the internal team.

Projects

None yet

Milestone

7.0 Preview2

Development

Successfully merging this pull request may close these issues.

7 participants

@Danil-Andrianov @SergeySmirnov-Akvelon @Cassie-Li01 @John-Qiao @RussKie @dreddy-work @vladimir-krestov