Added UIA support for split container#6519
Merged
dreddy-work merged 1 commit intodotnet:mainfrom Feb 18, 2022
Merged
Conversation
fd99e0b to
c315936
Compare
Member
|
@Danil-Andrianov I'm having a hard time seeing what is different between the screenshots. |
Contributor
Author
|
@JeremyKuhne the difference is just in provider, please, check screenshots from Inspect. AI data are same in both cases. |
a39942f to
1395ee6
Compare
RussKie
previously approved these changes
Jan 28, 2022
70 tasks
dreddy-work
previously approved these changes
Feb 1, 2022
SergeySmirnov-Akvelon
previously approved these changes
Feb 2, 2022
Contributor
SergeySmirnov-Akvelon
left a comment
There was a problem hiding this comment.
Looks good if it works
Contributor
|
@Olina-Zhang - could you please test this change? |
1432f21
1395ee6 to
1432f21
Compare
Member
|
Tested this PR for splitContainer control in Accessibility tools, it supports UIA provider and no issue was found finally. |
Member
|
@Danil-Andrianov , can you please rebase this? |
1432f21 to
58bf120
Compare
vladimir-krestov
previously approved these changes
Feb 18, 2022
|
|
||
| namespace System.Windows.Forms.Tests | ||
| { | ||
| public class SplitContainer_SplitContainerAccessibilityObjectTests : IClassFixture<ThreadExceptionFixture> |
Contributor
There was a problem hiding this comment.
Suggested change
| public class SplitContainer_SplitContainerAccessibilityObjectTests : IClassFixture<ThreadExceptionFixture> | |
| public class SplitContainer_SplitContainerAccessibleObjectTests : IClassFixture<ThreadExceptionFixture> |
| @@ -26,9 +26,9 @@ public void SplitContainerAccessibilityObject_ControlType_IsPane_IfAccessibleRol | |||
| splitContainer.CreateControl(); | |||
Contributor
There was a problem hiding this comment.
Change "Accessible" in the test name as well
Comment on lines
+82
to
+88
| using var control = new SplitContainer | ||
| { | ||
| Name = "SplitContainer1", | ||
| AccessibleName = "TestName" | ||
| }; | ||
|
|
||
| var accessibleObject = new SplitContainer.SplitContainerAccessibleObject(control); |
Contributor
There was a problem hiding this comment.
Please use one style for all tests, as you did before:
Suggested change
| using var control = new SplitContainer | |
| { | |
| Name = "SplitContainer1", | |
| AccessibleName = "TestName" | |
| }; | |
| var accessibleObject = new SplitContainer.SplitContainerAccessibleObject(control); | |
| using SplitContainer control = new() | |
| { | |
| Name = "SplitContainer1", | |
| AccessibleName = "TestName" | |
| }; | |
| SplitContainer.SplitContainerAccessibleObject accessibleObject = new(control); |
58bf120 to
149a66d
Compare
149a66d to
ad985bc
Compare
Tanya-Solyanik
approved these changes
Feb 18, 2022
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thank you, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially implements #3421
Proposed changes
Customer Impact
Before update:
After update:
Regression?
Risk
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow