Merged
Conversation
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
Contributor
vladimir-krestov
left a comment
There was a problem hiding this comment.
Check accessibility properties and test the fix.
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/Panel.PanelAccessibleObject.cs
Outdated
Show resolved
Hide resolved
8cc748b to
ae4996f
Compare
dreddy-work
reviewed
Aug 25, 2021
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...ystem.Windows.Forms/tests/UnitTests/System/Windows/Forms/Panel.PanelAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
ae4996f to
b2657e2
Compare
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
This change looks good to me, except for the pending change to focusable property. Once that is in, I'll approve.
b2657e2 to
a922c82
Compare
70 tasks
Tanya-Solyanik
previously approved these changes
Aug 31, 2021
Member
|
@ArtemTatarinov , please unblock this conflict? |
Added unit tests ToString is simplified
a922c82 to
fe8a503
Compare
dreddy-work
approved these changes
Sep 2, 2021
Tanya-Solyanik
approved these changes
Sep 3, 2021
Contributor
Author
|
Approved by CTI team |
Contributor
|
Verified this issue with .NET SDK 7.0.100-alpha.1.21479.26, this issue is fixed. |
Member
|
Verified this issue with .NET SDK 7.0.100-alpha.1.21527.14, this issue is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Customer Impact
Before update:
ProviderDescription: "[pid:28324,providerId:0x4909EE Main:Nested [pid:25160,providerId:0x4909EE Main(parent link):Microsoft: MSAA Proxy (unmanaged:uiautomationcore.dll)]; Hwnd(parent link):Microsoft: HWND Proxy (unmanaged:uiautomationcore.dll)]"
After update:
ProviderDescription: "[pid:20624,providerId:0xB0CEE Main:Nested [pid:14560,providerId:0xB0CEE Main(parent link):Unidentified Provider (unmanaged:coreclr.dll)]; Hwnd(parent link):Microsoft: HWND Proxy (unmanaged:uiautomationcore.dll)]"
Regression?
Risk
Test methodology
Accessibility testing
Test environment(s)
Microsoft Windows [Version 10.0.19043.1165]
.NET SDK 6.0.100-rc.1.21416.15
Microsoft Reviewers: Open in CodeFlow