Skip to content

Implementing LinkLabel support UIA provider#5157

Merged
dreddy-work merged 1 commit intodotnet:mainfrom
lisoenot:Implement-linklabel-uia-support
Aug 2, 2021
Merged

Implementing LinkLabel support UIA provider#5157
dreddy-work merged 1 commit intodotnet:mainfrom
lisoenot:Implement-linklabel-uia-support

Conversation

@lisoenot
Copy link
Contributor

@lisoenot lisoenot commented Jun 25, 2021 •
edited
Loading

Related Issue: #3421

Proposed changes

  • Updated SupportsUiaProviders flag.
  • Implemented LinkLabel and LinkLabel.Link accessible objects.

Customer Impact

  • Improving development experience for LinkLabel control accessibility.

Regression?

  • No

Risk

  • Minimal

Screenshots

Before .NetFramework

LinkLabel Text

fr t

LinkLabel Link

fr l

LinkLabel MultipleLink Link

fr ml

After implementation

LinkLabel Text

after text

LinkLabel Link

after link

LinkLabel Link (for LinkLabel with several links)

after several link

Test methodology

  • Manual testing.
  • Unit tests.
  • Automation tests (to be implemented).

Accessibility testing

  • Inspect
  • Narrator
  • Accessibility Insights

Test environment(s)

.NET SDK:
Version: 6.0.0-preview.7.21358.2

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned lisoenot Jun 25, 2021
vladimir-krestov
vladimir-krestov reviewed Jun 28, 2021
View reviewed changes
Copy link
Contributor

@vladimir-krestov vladimir-krestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reworked

@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from 58466a9 to f1daa31 Compare June 28, 2021 10:31
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from f1daa31 to 5b71b3d Compare June 28, 2021 11:40
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from c0e1bf5 to 4066f74 Compare June 28, 2021 12:04
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from 4066f74 to d3cfb89 Compare June 28, 2021 12:23
vladimir-krestov
vladimir-krestov previously approved these changes Jun 28, 2021
View reviewed changes
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch 4 times, most recently from ff29679 to 62f1730 Compare June 30, 2021 08:56
vladimir-krestov
vladimir-krestov reviewed Jun 30, 2021
View reviewed changes
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from ea6bd57 to 10d5a81 Compare July 1, 2021 09:12
vladimir-krestov
vladimir-krestov reviewed Jul 1, 2021
View reviewed changes
vladimir-krestov
vladimir-krestov reviewed Jul 1, 2021
View reviewed changes
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from e0fe274 to b1b67c6 Compare July 2, 2021 06:33
@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Jul 20, 2021 

So, for now we decided to move IsAccessibilityObjectCreated in Control class and take it:

if (IsAccessibilityObjectCreated)
{
focusLink.AccessibleObject?.RaiseAutomationEvent(UiaCore.UIA.AutomationFocusChangedEventId);
}

Looks good.

@RussKie RussKie removed the 🚧 work in progress Work that is current in progress label Jul 20, 2021
vladimir-krestov
vladimir-krestov reviewed Jul 27, 2021
View reviewed changes
@vladimir-krestov vladimir-krestov added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jul 27, 2021
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from 584b569 to 5a4387a Compare July 27, 2021 07:49
@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Jul 27, 2021

Testers approved the fix ✔️

@vladimir-krestov vladimir-krestov added waiting-review This item is waiting on review by one or more members of team and removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) labels Jul 27, 2021
@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Jul 27, 2021

@dreddy-work, please check this.

dreddy-work
dreddy-work reviewed Jul 27, 2021
View reviewed changes
@dreddy-work dreddy-work added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jul 27, 2021
@lisoenot
Implement UIA provider support for LinkLabel
61456e0 
Updated "SupportsUiaProviders" flag
Refactored LinkLabelAccessibleObject class
Added and implemented LinkLabelLinkAccessibleObject class
Placed LinkLabel control with single link and LinkLabel control with 3 links on MultiplyControls form
Added unit tests
@lisoenot lisoenot force-pushed the Implement-linklabel-uia-support branch from 5a4387a to 61456e0 Compare July 28, 2021 15:38
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Jul 28, 2021
@dreddy-work
Copy link
Member

dreddy-work commented Jul 29, 2021

@Tanya-Solyanik , can you take a final look at this?

@vladimir-krestov vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Jul 30, 2021
dreddy-work
dreddy-work approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreddy-work dreddy-work merged commit 6bfef50 into dotnet:main Aug 2, 2021
@vladimir-krestov vladimir-krestov mentioned this pull request Aug 3, 2021
Closed
70 tasks
@lisoenot lisoenot deleted the Implement-linklabel-uia-support branch August 3, 2021 08:47
@Marie-Shi
Copy link

Marie-Shi commented Aug 5, 2021

Verified this pull with .Net 6.0.100-rc.1.21404.16 from latest main branch, it is fixed. Now LinkLabel support UIA provider, please see the below screenshot:
LinkLabel Text:
linklabel_text
LinkLabel Link:
linklabel_link
LinkLabel MultipleLink Text:
linklabel_textmmmml
LinkLabel MultipleLink Link:
linklabel_linkmmmml

@ghost ghost locked as resolved and limited conversation to collaborators Jan 27, 2022
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

@RussKie RussKie RussKie left review comments

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon SergeySmirnov-Akvelon left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

@dreddy-work dreddy-work dreddy-work approved these changes

@vladimir-krestov vladimir-krestov vladimir-krestov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lisoenot lisoenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lisoenot @Tanya-Solyanik @dreddy-work @vladimir-krestov @Marie-Shi @RussKie @SergeySmirnov-Akvelon