Support keyboard tooltips in `ListViewItem` by SergeySmirnov-Akvelon · Pull Request #4405 · dotnet/winforms

SergeySmirnov-Akvelon · 2020-12-23T12:10:38Z

Fixes #4320

Proposed changes

Added support for "IKeyboardToolTip" interface in "ListViewItem" class.
Added logic to show the tooltip for the focused ListViewItem when the user switches between items

Customer Impact

Before:

After:

Regression?

No

Risk

Minimal

Test methodology

Manually

Test environment(s)

Microsoft Windows [Version 10.0.19041.388]
.NET Core 5.0.100-rc.2.20479.15

Microsoft Reviewers: Open in CodeFlow

codecov · 2020-12-23T15:28:56Z

Codecov Report

Merging #4405 (2dc6c6a) into main (e805f92) will increase coverage by 0.00308%.
The diff coverage is 99.45155%.

@@                 Coverage Diff                 @@
##                main       #4405         +/-   ##
===================================================
+ Coverage   97.96079%   97.96387%   +0.00307%     
===================================================
  Files            542         543          +1     
  Lines         263533      264080        +547     
  Branches        4937        4966         +29     
===================================================
+ Hits          258159      258703        +544     
  Misses          4494        4494                 
- Partials         880         883          +3

Flag	Coverage Δ
Debug	`97.96387% <99.45155%> (+0.00307%)`	⬆️
test	`97.96387% <99.45155%> (+0.00307%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

RussKie · 2021-01-04T06:34:09Z

src/System.Windows.Forms/src/PublicAPI.Unshipped.txt

Why are we adding new public API?

Thank you. Reverted

SergeySmirnov-Akvelon · 2021-01-05T13:56:31Z

src/System.Windows.Forms/src/System/Windows/Forms/ToolTip.cs

Hi @JeremyKuhne. Could you please share your opinion about these changes?
Without these changes we see a bug for keyboard tooltip (it is displayed every second time).

Keyboard tooltip works correctly with changes

Mouse tooltip works correctly with and without changes.

RussKie

LGTM with few stylistic comments. Have you resolved double tooltip issue?

RussKie · 2021-01-12T01:44:28Z

src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.cs

[nit] This method should be above IKeyboardToolTip.GetNativeScreenRectangle()
Strive to keep members alphabetised

SergeySmirnov-Akvelon · 2021-01-14T06:40:07Z

LGTM with few stylistic comments. Have you resolved double tooltip issue?

We added logic to hide the keyboard tooltip in the code that is responsible for displaying the mouse tooltip

vladimir-krestov

Nice work!
Have some refactoring points and points from #4466

src/System.Windows.Forms/src/System/Windows/Forms/ToolTip.cs

src/System.Windows.Forms/src/System/Windows/Forms/KeyboardToolTip.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListView.cs

vladimir-krestov

Additional points

src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListViewGroupItemCollection.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewNativeItemCollection.cs

vladimir-krestov

Few comments

src/System.Windows.Forms/src/System/Windows/Forms/ListView.ListViewNativeItemCollection.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListView.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.IKeyboardToolTip.cs

src/System.Windows.Forms/src/System/Windows/Forms/ListViewItem.cs

src/System.Windows.Forms/src/System/Windows/Forms/ToolTip.cs

RussKie · 2021-02-22T09:35:21Z

MC, also please resolve resolved comments.

SergeySmirnov-Akvelon · 2021-02-26T06:12:45Z

CTI approved

RussKie · 2021-03-01T01:57:39Z

Please clean up the history.

The issue is reproduced, because when user navigates using keyboard, the message for displaying of the tooltip is not called. Added support for "IKeyboardToolTip" interface in "ListViewItem" class. Added logic to show the tooltip for the focused ListViewItem when the user switches between items

SergeySmirnov-Akvelon requested a review from a team as a code owner December 23, 2020 12:10

ghost assigned SergeySmirnov-Akvelon Dec 23, 2020

SergeySmirnov-Akvelon marked this pull request as draft December 23, 2020 12:11

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from 73bd292 to f07efb4 Compare December 23, 2020 14:33

RussKie reviewed Jan 4, 2021

View reviewed changes

SergeySmirnov-Akvelon commented Jan 5, 2021

View reviewed changes

SergeySmirnov-Akvelon marked this pull request as ready for review January 6, 2021 12:18

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from dd5c010 to 6837145 Compare January 6, 2021 13:19

SergeySmirnov-Akvelon marked this pull request as draft January 11, 2021 07:16

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from 6837145 to edb7766 Compare January 11, 2021 08:52

SergeySmirnov-Akvelon marked this pull request as ready for review January 11, 2021 08:53

SergeySmirnov-Akvelon added the waiting-review This item is waiting on review by one or more members of team label Jan 11, 2021

RussKie reviewed Jan 12, 2021

View reviewed changes

RussKie added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 12, 2021

ghost removed the waiting-author-feedback The team requires more information from the author label Jan 12, 2021

SergeySmirnov-Akvelon added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jan 18, 2021

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from 76cfa1d to f6d4919 Compare January 26, 2021 06:43

RussKie changed the title ~~[Accessibility] ListViewItem has no keyboard tooltip #4320~~ Support keyboard tooltips in ListViewItem Jan 29, 2021

vladimir-krestov reviewed Jan 29, 2021

View reviewed changes

Base automatically changed from master to main February 1, 2021 04:50

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch 4 times, most recently from 366783f to 559dc4d Compare February 8, 2021 08:36

vladimir-krestov reviewed Feb 8, 2021

View reviewed changes

SergeySmirnov-Akvelon added the waiting-review This item is waiting on review by one or more members of team label Feb 15, 2021

RussKie added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Feb 22, 2021

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from e6b7614 to 663c4c3 Compare February 24, 2021 06:58

ghost removed the waiting-author-feedback The team requires more information from the author label Feb 24, 2021

SergeySmirnov-Akvelon removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Feb 26, 2021

RussKie previously approved these changes Mar 1, 2021

View reviewed changes

RussKie added the waiting-author-feedback The team requires more information from the author label Mar 1, 2021

SergeySmirnov-Akvelon dismissed RussKie’s stale review via e492c4c March 1, 2021 08:46

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from 663c4c3 to e492c4c Compare March 1, 2021 08:46

ghost removed the waiting-author-feedback The team requires more information from the author label Mar 1, 2021

SergeySmirnov-Akvelon added 2 commits March 1, 2021 11:49

Added unit tests

64c2aec

SergeySmirnov-Akvelon force-pushed the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch from e492c4c to 64c2aec Compare March 1, 2021 08:52

RussKie approved these changes Mar 1, 2021

View reviewed changes

RussKie merged commit a4c26da into dotnet:main Mar 1, 2021

RussKie deleted the Issue-4320_ListViewItem_has_no_keyboard_tooltip branch March 1, 2021 23:30

ghost added this to the 6.0 Preview3 milestone Mar 1, 2021

ghost locked as resolved and limited conversation to collaborators Jan 29, 2022

Conversation

SergeySmirnov-Akvelon commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Test methodology

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

codecov bot commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RussKie Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

SergeySmirnov-Akvelon Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

SergeySmirnov-Akvelon Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

RussKie Jan 6, 2021

Choose a reason for hiding this comment

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

RussKie Jan 12, 2021

Choose a reason for hiding this comment

Uh oh!

SergeySmirnov-Akvelon commented Jan 14, 2021

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RussKie commented Feb 22, 2021

Uh oh!

SergeySmirnov-Akvelon commented Feb 26, 2021

Uh oh!

RussKie commented Mar 1, 2021

Uh oh!

Reviewers

SergeySmirnov-Akvelon commented Dec 23, 2020 •

edited

Loading

codecov bot commented Dec 23, 2020 •

edited

Loading