Implementing LegacyIAccessiblePattern supporting for ControlAccessibleObject#3412
Merged
RussKie merged 1 commit intodotnet:masterfrom Jun 11, 2020
Conversation
RussKie
reviewed
Jun 10, 2020
Contributor
There was a problem hiding this comment.
How do we ensure expected != true?
Contributor
Author
There was a problem hiding this comment.
This is a fundamental point. At the moment, Control as a type has SupportsUiaProvider as false. We can't just set it as true because it will break all Accessibility. So in the nearest future, SupportsUiaProvider will be false.
I can add Assert.False(expected) in the test to make sure, that is right.
Please, correct me if I understood this incorrectly.
Thanks.
for all control accessible objects, which support uia provider
0b15d1b to
1d8a8ad
Compare
RussKie
approved these changes
Jun 11, 2020
Contributor
|
Thank you |
This was referenced Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3410
Proposed changes
IsPatternSupportedforLegacyIAccessiblePatternIdas true inControlAccessibleObject. It will cause all control accessible objects to implement LegacyIAccessible.Customer Impact
Regression?
Risk
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow