Adding Splitter UIA accessibility#3246
Merged
RussKie merged 6 commits intodotnet:masterfrom Jun 29, 2020
Merged
Conversation
Contributor
There was a problem hiding this comment.
This would not be needed if you add support for UIA_LegacyIAccessiblePatternId. We have to continue supporting the MSAA, so please re-add the legacy pattern.
Contributor
There was a problem hiding this comment.
Can we devise tests that iterate over all AccessibleObject implementations in our codebase and verify we have necessary implementations?
Contributor
There was a problem hiding this comment.
We found out it is necessary. If we remove this line then "Name" property returns wrong value. The "SplitterAccessibleObject_GetPropertyValue_returns_correct_values" test is added for it.
RussKie
previously approved these changes
Jun 9, 2020
0c6e1c1 to
91be4cc
Compare
RussKie
previously approved these changes
Jun 9, 2020
Contributor
|
@SergeySmirnov-Akvelon I have rebased and applied few tweaks. Please have a look and complete the outstanding. Thank you |
70 tasks
0afde75 to
3f291ba
Compare
Switching Splitter accessibility to UIA providers.
3f291ba to
cd96782
Compare
763747d to
6402c2d
Compare
RussKie
reviewed
Jun 25, 2020
...em.Windows.Forms/tests/UnitTests/AccessibleObjects/Splitter.SplitterAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms/tests/UnitTests/AccessibleObjects/Splitter.SplitterAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
RussKie
previously approved these changes
Jun 25, 2020
Contributor
vladimir-krestov
left a comment
There was a problem hiding this comment.
Looks good. I don't see any critical errors
src/System.Windows.Forms/src/System/Windows/Forms/Splitter.SplitterAccessibleObject.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms/tests/UnitTests/AccessibleObjects/Splitter.SplitterAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms/tests/UnitTests/AccessibleObjects/Splitter.SplitterAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms/tests/UnitTests/AccessibleObjects/Splitter.SplitterAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
024fa16 to
c36a3a7
Compare
c36a3a7 to
8c7668c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3246 +/- ##
====================================================
+ Coverage 66.95113% 98.51872% +31.56758%
====================================================
Files 1338 447 -891
Lines 504925 251944 -252981
Branches 40866 4148 -36718
====================================================
- Hits 338053 248212 -89841
+ Misses 161315 3019 -158296
+ Partials 5557 713 -4844
|
RussKie
previously approved these changes
Jun 26, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RussKie
approved these changes
Jun 29, 2020
vladimir-krestov
approved these changes
Jun 29, 2020
Contributor
|
CTI approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3245
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Test environment(s)
.NET Core 5.0
Version: 5.0.100-alpha.1.20073.10
Commit: 29f4d693a9
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-alpha1-05536
Host (useful for support):
Version: 5.0.0-alpha.1.20072.3
Commit: c3dc1fdfdc
Microsoft Reviewers: Open in CodeFlow