Adding UIA provider support to RadioButtonAccessibleObject by M-Lipin · Pull Request #3244 · dotnet/winforms

M-Lipin · 2020-05-08T18:40:51Z

Moving RadioButtonAccessibleObject to separate file.

Fixes #3243

Proposed changes

Adding UIA providers support for RadioButton control accessibility.
Moving RadioButtonAccessibleObject to separate file.

Customer Impact

Improving development experience for ListView control accessibility.
Prerequisite for Narrator focus is not moving in proper logical order when user is navigating by using caps + arrow keys (tab index is ignored) #2164.

Regression?

No

Risk

Minimal

Screenshots

Before

After

Test methodology

Manual testing;
Unit testing;
UI automation tests.

Accessibility testing

Inspect and Accessibility Insights.
Accessibility client apps.

Test environment(s)

.NET Core 5.0
Version: 5.0.100-alpha.1.20073.10
Commit: 29f4d693a9
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-alpha1-05536
Host (useful for support):
Version: 5.0.0-alpha.1.20072.3
Commit: c3dc1fdfdc

Microsoft Reviewers: Open in CodeFlow

RussKie

Please rebase, correct NRT, and add tests.

Tanya-Solyanik · 2020-05-20T15:56:39Z

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

Is this case needed after you add support for legacy accessibility?

Yes. It's required for keeping of old behavior for "Name" property

Yes, as I found out it is necessary. Then we can have the ability to change AccessibleName. If we remove this line we will get the following result as for Label control:

RadioButtonAccessibleObject_GetPropertyValue_returns_correct_values unit test should confirm this.

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

RussKie

Looks good 👍

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.cs

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.cs

codecov · 2020-06-05T12:38:56Z

Codecov Report

Merging #3244 into master will decrease coverage by 27.93988%.
The diff coverage is 95.52239%.

@@                 Coverage Diff                  @@
##              master       #3244          +/-   ##
====================================================
- Coverage   62.14766%   34.20778%   -27.93989%     
====================================================
  Files           1257         891         -366     
  Lines         449428      253875      -195553     
  Branches       39227       36798        -2429     
====================================================
- Hits          279309       86845      -192464     
+ Misses        164638      162261        -2377     
+ Partials        5481        4769         -712

Flag	Coverage Δ
#Debug	`34.20778% <95.52239%> (-27.93989%)`	⬇️
#production	`34.20778% <95.52239%> (+0.86585%)`	⬆️
#test	`?`

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs

codecov · 2020-06-08T09:26:34Z

Codecov Report

Merging #3244 into master will decrease coverage by 27.85816%.
The diff coverage is 95.52239%.

@@                 Coverage Diff                  @@
##              master       #3244          +/-   ##
====================================================
- Coverage   62.14766%   34.28950%   -27.85817%     
====================================================
  Files           1257         891         -366     
  Lines         449428      253827      -195601     
  Branches       39227       36791        -2436     
====================================================
- Hits          279309       87036      -192273     
+ Misses        164638      162003        -2635     
+ Partials        5481        4788         -693

Flag	Coverage Δ
#Debug	`34.28950% <95.52239%> (-27.85817%)`	⬇️
#production	`34.28950% <95.52239%> (+0.94756%)`	⬆️
#test	`?`

RussKie

Looks good 👍, minor tweaks to the tests and it's ready to go

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTests.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTests.cs

codecov · 2020-06-18T07:39:53Z

Codecov Report

Merging #3244 into master will increase coverage by 31.91594%.
The diff coverage is 100.00000%.

@@                 Coverage Diff                  @@
##              master       #3244          +/-   ##
====================================================
+ Coverage   66.58991%   98.50585%   +31.91593%     
====================================================
  Files           1338         444         -894     
  Lines         501564      248101      -253463     
  Branches       40847        4091       -36756     
====================================================
- Hits          333991      244394       -89597     
+ Misses        162033        2999      -159034     
+ Partials        5540         708        -4832

Flag	Coverage Δ
#Debug	`98.50585% <100.00000%> (+31.91593%)`	⬆️
#production	`?`
#test	`98.50585% <100.00000%> (+0.00032%)`	⬆️

vladimir-krestov

Looks good

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.cs

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTests.cs

codecov · 2020-06-25T12:49:12Z

Codecov Report

Merging #3244 into master will decrease coverage by 31.03273%.
The diff coverage is 95.16129%.

@@                 Coverage Diff                  @@
##              master       #3244          +/-   ##
====================================================
- Coverage   66.58991%   35.55718%   -31.03273%     
====================================================
  Files           1338         893         -445     
  Lines         501564      253150      -248414     
  Branches       40847       36718        -4129     
====================================================
- Hits          333991       90013      -243978     
+ Misses        162033      158288        -3745     
+ Partials        5540        4849         -691

Flag	Coverage Δ
#Debug	`35.55718% <95.16129%> (-31.03274%)`	⬇️
#production	`35.55718% <95.16129%> (+0.19401%)`	⬆️
#test	`?`

...dows.Forms/tests/UnitTests/AccessibleObjects/RadioButton.RadioButtonAccessibleObjectTests.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.cs

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs

SergeySmirnov-Akvelon · 2020-06-30T07:20:07Z

CTI approved

Moving RadioButtonAccessibleObject to separate file.

M-Lipin requested a review from a team as a code owner May 8, 2020 18:40

ghost assigned M-Lipin May 8, 2020

M-Lipin changed the title ~~Adding UIA provider support to RadioButtonAccessibleObject.~~ Adding UIA provider support to RadioButtonAccessibleObject May 8, 2020

M-Lipin assigned Ryuugamine May 11, 2020

RussKie suggested changes May 20, 2020

View reviewed changes

ghost added the waiting-author-feedback The team requires more information from the author label May 20, 2020

Tanya-Solyanik reviewed May 20, 2020

View reviewed changes

RussKie reviewed Jun 5, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs Outdated Show resolved Hide resolved

RussKie reviewed Jun 5, 2020

View reviewed changes

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.cs Outdated Show resolved Hide resolved

hughbe reviewed Jun 8, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs Outdated Show resolved Hide resolved

hughbe reviewed Jun 8, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTest.cs Outdated Show resolved Hide resolved

RussKie reviewed Jun 9, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTests.cs Outdated Show resolved Hide resolved

RussKie reviewed Jun 10, 2020

View reviewed changes

src/System.Windows.Forms/src/System/Windows/Forms/RadioButton.RadioButtonAccessibleObject.cs Outdated Show resolved Hide resolved

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/RadioButtonAccessibleObjectTests.cs Outdated Show resolved Hide resolved

RussKie mentioned this pull request Jun 10, 2020

Fixng 3214 - UIA providers support for Button control #3215

Merged

vladimir-krestov mentioned this pull request Jun 10, 2020

Epic - [Accessibility] Implement UIA provider for all controls #3421

Closed

70 tasks

SergeySmirnov-Akvelon force-pushed the Issue_3243_RadioButton_accessibility_UIA branch 2 times, most recently from 8300dd1 to 0df9a1d Compare June 18, 2020 07:20

vladimir-krestov reviewed Jun 25, 2020

View reviewed changes

RussKie suggested changes Jun 26, 2020

View reviewed changes

SergeySmirnov-Akvelon force-pushed the Issue_3243_RadioButton_accessibility_UIA branch 2 times, most recently from 1ba06f0 to 94fcc34 Compare June 26, 2020 12:43

SergeySmirnov-Akvelon removed the waiting-author-feedback The team requires more information from the author label Jun 26, 2020

SergeySmirnov-Akvelon force-pushed the Issue_3243_RadioButton_accessibility_UIA branch 2 times, most recently from ae587d2 to 601416c Compare June 26, 2020 14:24

SergeySmirnov-Akvelon added the waiting-review This item is waiting on review by one or more members of team label Jun 26, 2020

RussKie previously approved these changes Jun 29, 2020

View reviewed changes

RussKie assigned SergeySmirnov-Akvelon and unassigned Ryuugamine Jun 29, 2020

vladimir-krestov previously approved these changes Jun 29, 2020

View reviewed changes

vladimir-krestov added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 29, 2020

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Jun 29, 2020

SergeySmirnov-Akvelon removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 30, 2020

Mikhail Lipin and others added 3 commits June 30, 2020 12:17

Adding UIA provider support to RadioButtonAccessibleObject.

aee0d5f

Moving RadioButtonAccessibleObject to separate file.

Adding raising UIA event on checked state change. Added unit tests.

1fe59c2

Enabled NRT

1473fd7

SergeySmirnov-Akvelon dismissed stale reviews from vladimir-krestov and RussKie via 1473fd7 June 30, 2020 09:23

SergeySmirnov-Akvelon force-pushed the Issue_3243_RadioButton_accessibility_UIA branch from 601416c to 1473fd7 Compare June 30, 2020 09:23

RussKie approved these changes Jun 30, 2020

View reviewed changes

RussKie merged commit eff8a5d into dotnet:master Jun 30, 2020

RussKie deleted the Issue_3243_RadioButton_accessibility_UIA branch June 30, 2020 11:39

ghost added this to the 5.0 Preview8 milestone Jun 30, 2020

ghost locked as resolved and limited conversation to collaborators Feb 1, 2022

Conversation

M-Lipin commented May 8, 2020 • edited by RussKie Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

Tanya-Solyanik May 20, 2020

Choose a reason for hiding this comment

Uh oh!

SergeySmirnov-Akvelon Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

vladimir-krestov Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 5, 2020

Codecov Report

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 8, 2020

Codecov Report

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 18, 2020

Codecov Report

Uh oh!

vladimir-krestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 25, 2020

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SergeySmirnov-Akvelon commented Jun 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

M-Lipin commented May 8, 2020 •

edited by RussKie

Loading