Skip to content

Adding UIA accessibility support for PictureBox control#3233

Merged
RussKie merged 5 commits intodotnet:masterfrom
M-Lipin:Issue_3232_PictureBox_does_not_support_UIA_accessibility
Jun 29, 2020
Merged

Adding UIA accessibility support for PictureBox control#3233
RussKie merged 5 commits intodotnet:masterfrom
M-Lipin:Issue_3232_PictureBox_does_not_support_UIA_accessibility

Conversation

@M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented May 6, 2020 •
edited by RussKie
Loading

Fixes #3232

Proposed changes

  • Adding UIA accessibility support for PictureBox control.
  • Moving PictureBox accessible object implementation to a separate file.

Customer Impact

Regression?

  • No

Risk

  • Minimal

Screenshots

Before

image

After

image

Test methodology

  • Manual testing;
  • Unit tests (to be implemented);
  • UI automation.

Accessibility testing

  • Inspect;
  • Accessibility Insights;
  • Narrator and other accessibility client apps.

Test environment(s)

.NET Core 5.0
Version: 5.0.100-alpha.1.20073.10
Commit: 29f4d693a9
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-alpha1-05536
Host (useful for support):
Version: 5.0.0-alpha.1.20072.3
Commit: c3dc1fdfdc

Microsoft Reviewers: Open in CodeFlow

@M-Lipin M-Lipin requested a review from a team as a code owner May 6, 2020 21:19
@ghost ghost assigned M-Lipin May 6, 2020
RussKie
RussKie suggested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests

@ghost ghost added the waiting-author-feedback The team requires more information from the author label May 7, 2020
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label May 11, 2020
@RussKie RussKie added the waiting-author-feedback The team requires more information from the author label May 20, 2020
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon force-pushed the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch from 7e8e0af to be6ff17 Compare June 5, 2020 14:16
@vladimir-krestov vladimir-krestov mentioned this pull request Jun 10, 2020
Closed
70 tasks
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon force-pushed the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch 3 times, most recently from 2de885e to d2034fa Compare June 18, 2020 08:51
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon force-pushed the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch 2 times, most recently from db661d6 to 6fd90d5 Compare June 24, 2020 13:42
RussKie
RussKie reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vladimir-krestov
vladimir-krestov reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@vladimir-krestov vladimir-krestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 26, 2020
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon force-pushed the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch from 03ea533 to b0861aa Compare June 26, 2020 14:49
@SergeySmirnov-Akvelon SergeySmirnov-Akvelon added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Jun 26, 2020
RussKie
RussKie previously approved these changes Jun 29, 2020
View reviewed changes
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Jun 29, 2020
@vladimir-krestov vladimir-krestov dismissed stale reviews from RussKie and themself via 1561cd5 June 29, 2020 05:36
@vladimir-krestov vladimir-krestov force-pushed the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch from b0861aa to 1561cd5 Compare June 29, 2020 05:36
@vladimir-krestov vladimir-krestov removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Jun 29, 2020
@vladimir-krestov
Copy link
Contributor

vladimir-krestov commented Jun 29, 2020

Testers approved the fix ✔️

@RussKie RussKie merged commit 1678a75 into dotnet:master Jun 29, 2020
@RussKie RussKie deleted the Issue_3232_PictureBox_does_not_support_UIA_accessibility branch June 29, 2020 06:17
@ghost ghost added this to the 5.0 Preview8 milestone Jun 29, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@weltkante weltkante weltkante left review comments

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon SergeySmirnov-Akvelon left review comments

@RussKie RussKie RussKie approved these changes

@vladimir-krestov vladimir-krestov vladimir-krestov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@M-Lipin M-Lipin

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon

Labels

None yet

Projects

None yet

Milestone

5.0 Preview8

Development

Successfully merging this pull request may close these issues.

PictureBox control does not support UIA accessibility

6 participants

@M-Lipin @vladimir-krestov @RussKie @weltkante @SergeySmirnov-Akvelon @Ryuugamine