Skip to content

WIP: Fixing Narrator caps navigation to take into account control tab index#2167

Closed
M-Lipin wants to merge 1 commit intorelease/3.1from
dev/v-milipi/Issue_2164_Narrator_caps_navigation
Closed

WIP: Fixing Narrator caps navigation to take into account control tab index#2167
M-Lipin wants to merge 1 commit intorelease/3.1from
dev/v-milipi/Issue_2164_Narrator_caps_navigation

Conversation

@M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented Oct 23, 2019 •
edited
Loading

Fixes #2164

Proposed changes

  • Adding UIA navigation to the Form control;
  • Adding UIA support for Control;
  • Adding UIA previous and next navigation to base Control.

Customer Impact

  • Narrator caps navigation will take into account control tab index.
  • There will be no mismatch between common tab navigation accompanied with Narrator announcement and Narrator caps navigation.

Regression?

  • No

Risk

  • Middle risk as requires switching to UIA for all controls. Need to rebase on 5.0.

Screenshots

Before

image

After

  • To be added (work in progress).

Test methodology

  • To be tested.

Accessibility testing

  • To be added.

Test environment(s)

  • To be added.
Microsoft Reviewers: Open in CodeFlow

@M-Lipin M-Lipin requested a review from a team as a code owner October 23, 2019 12:22
@M-Lipin M-Lipin added this to the 5.0 milestone Oct 23, 2019
@M-Lipin M-Lipin changed the title Initial change to fix Narrator caps+arrow navigation across the Form … WIP: Fixing Narrator caps navigation to take into account control tab index Oct 23, 2019
@M-Lipin M-Lipin self-assigned this Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019 •
edited
Loading

Codecov Report

Merging #2167 into release/3.1 will increase coverage by 0.00239%.
The diff coverage is 0%.

@@                  Coverage Diff                  @@
##           release/3.1       #2167         +/-   ##
=====================================================
+ Coverage     26.50723%   26.50962%   +0.00239%     
=====================================================
  Files              806         806                 
  Lines           268108      268114          +6     
  Branches         38070       38071          +1     
=====================================================
+ Hits             71068       71076          +8     
+ Misses          191957      191955          -2     
  Partials          5083        5083
Flag Coverage Δ
#Debug 26.50962% <0%> (+0.00239%) ⬆️
#production 26.50962% <0%> (+0.00239%) ⬆️
#test 100% <ø> (?)

@RussKie
Copy link
Contributor

RussKie commented Oct 29, 2019

@merriemcgaw would you think we can move it to 5.0 due to all the complexity and amount of work required?

@M-Lipin M-Lipin mentioned this pull request Apr 3, 2020
Closed
3 tasks
@M-Lipin
Copy link
Contributor Author

M-Lipin commented Apr 3, 2020

Closing this PR and reopened to work from fork branch: #3037

@M-Lipin M-Lipin closed this Apr 3, 2020
@RussKie RussKie deleted the dev/v-milipi/Issue_2164_Narrator_caps_navigation branch April 22, 2020 00:55
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@M-Lipin M-Lipin

Labels

None yet

Projects

None yet

Milestone

5.0 Previews 1-4

Development

Successfully merging this pull request may close these issues.

2 participants

@M-Lipin @RussKie