[release/10.0] Fix Region update logic to ensure Region updates are applied correctly when handle is created #14035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merriemcgaw
approved these changes
Nov 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/10.0 #14035 +/- ##
======================================================
+ Coverage 77.10282% 77.13962% +0.03679%
======================================================
Files 3273 3273
Lines 644979 645033 +54
Branches 47701 47701
======================================================
+ Hits 497297 497576 +279
+ Misses 144002 143780 -222
+ Partials 3680 3677 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
approved these changes
Nov 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14022 to release/10.0
/cc @JeremyKuhne @LeafShi1
Customer Impact
When setting a Region on a Control before it is created, it won't be applied when the Control is finally created. This was regressed early in .NET 10 development.
The workaround is after construction to get the Region, set a null Region, then put back the original Region. While this will set the correct Region to the HWND it may have side effects.
Testing
Manual testing and regression tests.
Risk
Low. Removed an added boolean logic error.