[release/10.0] Move LinkLabel text region dispose back to EnsureRun #13979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disposing in InvalidateLayout would break when accessing the links VisualRegion as it is shared. Fixes #13973
Shyam-Gupta
approved these changes
Oct 21, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/10.0 #13979 +/- ##
======================================================
+ Coverage 77.10112% 77.10239% +0.00127%
======================================================
Files 3273 3273
Lines 644931 644932 +1
Branches 47692 47692
======================================================
+ Hits 497249 497258 +9
+ Misses 144014 144004 -10
- Partials 3668 3670 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13978 to release/10.0
/cc @JeremyKuhne
Customer Impact
Changing
LinkLabelstate during events can cause the app to crash as we'll try to give GDI+ a null pointer. There is no known workaround to this as internal state can't be changed as events are being processed.A System.Drawing
Regiondisposal was moved to a location that would let it get used after disposal by another holder of the Region. The fix is to move the disposal back to its original location.Testing
Manual testing of the end users' repro. Existing automated coverage.
This is not plausible to unit test as it requires a long sequence of messages to reproduce. (MouseEnter, MouseHover, MouseUp, and more.)
Risk
Low. Moving the disposal back to where it was originally, which is before the new
Regionis created and applied.Microsoft Reviewers: Open in CodeFlow