Switch to System.Formats.Nrbf #11745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all, simply the SerializationRecord from System.Formats.Nrbf
…parsing and deserialization (not needed anymore)
adamsitnik
commented
Jul 24, 2024
| { | ||
| return NrbfDecoder.Decode(stream, leaveOpen: true); | ||
| } | ||
| catch (Exception ex) when(ex is ArgumentException or InvalidCastException or ArithmeticException or IOException) |
Member
Author
There was a problem hiding this comment.
Here I wanted to keep the same exception handling:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11745 +/- ##
===================================================
+ Coverage 74.69499% 74.79155% +0.09655%
===================================================
Files 3045 3021 -24
Lines 630638 629289 -1349
Branches 46862 46689 -173
===================================================
- Hits 471055 470655 -400
+ Misses 156224 155274 -950
- Partials 3359 3360 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
JeremyKuhne
approved these changes
Jul 24, 2024
Member
JeremyKuhne
left a comment
There was a problem hiding this comment.
Thanks for updating this!
This was referenced Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit (7db91c1), I've introduced a set of extensions that don't use
BinaryFormattedObjectat all, just theSerializationRecordfrom System.Formats.Nrbf.Then I've realized that
BinaryFormattedObject.Deserializeis not used by the product anymore, so I've removed it and everything related to parsing. All I kept is the writing logic and its tests.This was possible because the deserializer that @JeremyKuhne has authored was moved to dotnet/runtime in dotnet/runtime#102379.
Microsoft Reviewers: Open in CodeFlow