Reduce nesting in LinkLabel #10448
Merged
Reduce nesting in LinkLabel #10448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an example of how nesting can be reduced. Basic techniques: - Inverting if blocks - Adding early outs - Moving larger blocks into nested functions I updated a few additional types. Additionally: - Override Dispose(bool) on LinkLabel to ensure we release the GDI+ resources - Remove the null-forgiving operator from LinkLabel (without a major refactor)
Tanya-Solyanik
previously approved these changes
Dec 8, 2023
| CreateTextFormatFlags(clientAreaMinusPadding.Size) | ||
| #if DEBUG | ||
| // Skip the asserts in TextRenderer because the DC has been modified | ||
| | TextRenderer.SkipAssertFlag |
Contributor
There was a problem hiding this comment.
This line should be indented. It might be more readable to put the #if DEBUG around the whole method call.
lonitra
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how nesting can be reduced. Basic techniques:
I updated a few additional types. Additionally:
Microsoft Reviewers: Open in CodeFlow