Conversation
Codecov Report
@@ Coverage Diff @@
## master #1027 +/- ##
==================================================
- Coverage 32.1871% 32.18549% -0.00162%
==================================================
Files 1097 1098 +1
Lines 297585 297951 +366
Branches 38375 38413 +38
==================================================
+ Hits 95784 95897 +113
- Misses 197609 197854 +245
- Partials 4192 4200 +8
|
src/System.Windows.Forms/src/System/Windows/Forms/AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/ListBoxAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
suggested changes
May 24, 2019
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
test looks good. I think my questions are mostly about @M-Lipin 's changes :)
M-Lipin
reviewed
Jun 3, 2019
| /// <devdoc> | ||
| /// Returns true if this control has focus. | ||
| /// </devdoc> | ||
| public override bool Focused |
Contributor
There was a problem hiding this comment.
What is the main difference between overridden implementation and Control.Focused?
Contributor
Author
There was a problem hiding this comment.
The implementation of this property does not make much sense. I removed it. Thanks.
M-Lipin
reviewed
Jun 3, 2019
M-Lipin
reviewed
Jun 3, 2019
M-Lipin
reviewed
Jun 3, 2019
M-Lipin
reviewed
Jun 3, 2019
M-Lipin
reviewed
Jun 3, 2019
M-Lipin
reviewed
Jun 3, 2019
RussKie
reviewed
Jun 5, 2019
Contributor
RussKie
left a comment
There was a problem hiding this comment.
IIUIC, 4daafe4 is a mix of functional changes and refactoring (methods moved).
This makes the diff destructive and impossible to see what functional changes in fact are...
I understand and fully support the idea of cleaning and making up the code, however it must be done as a separate commit.
| { | ||
| return state |= AccessibleStates.Selected | AccessibleStates.Focused; | ||
| } | ||
| else |
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed.
Contributor
Author
|
@RussKie , thanks. I will fix it. |
drewnoakes
reviewed
Jun 5, 2019
RussKie
reviewed
Jun 11, 2019
RussKie
reviewed
Jun 17, 2019
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/ListBoxAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Jun 18, 2019
Contributor
RussKie
left a comment
There was a problem hiding this comment.
LGTM 👍
We'll need to tidy up the commits before the merge
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
approved these changes
Jun 20, 2019
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, thank you! my comments are minor
d00b389 to
979dc75
Compare
RussKie
reviewed
Jun 26, 2019
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.ItemAccessibleObject.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.AccessibleObject.cs
Outdated
Show resolved
Hide resolved
979dc75 to
b6202e0
Compare
Member
|
@vladimir-krestov , how are we doing with this one? |
RussKie
reviewed
Jul 14, 2020
src/System.Windows.Forms/src/System/Windows/Forms/ListBox.AccessibleObject.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #932 and related to #1026.
The pull request adds new changes and replaces pull request #935.