Remove cohosting setting and hardcode the value to true#8810
Remove cohosting setting and hardcode the value to true#8810phil-allen-msft merged 11 commits intodotnet:mainfrom
Conversation
dibarbet
left a comment
There was a problem hiding this comment.
can you also drop down the max vsix size on teh artifact tests, so we don't lose the improvement?
https://github.com/dotnet/vscode-csharp/blob/main/test/lsptoolshost/artifactTests/vsix.test.ts
dibarbet
left a comment
There was a problem hiding this comment.
since we're deleting so much code I would also be curious if there is an improvement to the extension code load time. You can see the numbers via the perfview.show command. For example for the current version on my machine
|
Not as exciting as I would have hoped, but with both from local builds of the extension:
this branch:
What's perhaps more interesting is that "Finish Activate" time was dreadful until I manually deleted my local |
interesting! -50ms isn't too bad (still have a lot of O# code). will try it out once we have an official build as well |
Part of dotnet/razor#12491
Removes the bits of the C# extension that are for the non-cohosting editor. The OmniSharp setting still works as normal. I did it in bits, so commit-at-a-time might make sense, but most of it is just deleting whole files so GitHub hopefully will do a decent job.
There is a bit more cleanup that could happen, and could move some things around now that there is only one Razor system, could remove the word "cohost" from everything etc. but didn't want to make the PR too painful. Will need follow ups anyway, as bits form Roslyn and Razor are removed etc.
Reduces the VSIX size by about 40mb. I'll be honest, I was hoping for more :P