Skip to content

[release/8.0.1xx] Update dependencies from dotnet/arcade#9574

Merged
marcpopMSFT merged 4 commits intodarc-release/8.0.1xx-f6e867c1-48f5-42dd-816b-a2309476fb1ffrom
copilot/sub-pr-9564
Nov 26, 2025
Merged

[release/8.0.1xx] Update dependencies from dotnet/arcade#9574
marcpopMSFT merged 4 commits intodarc-release/8.0.1xx-f6e867c1-48f5-42dd-816b-a2309476fb1ffrom
copilot/sub-pr-9564

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025 •
edited
Loading

Problem

Updates Microsoft.DotNet.Arcade.Sdk from 8.0.0-beta.25563.4 to 8.0.0-beta.25574.4. The arcade update introduced stricter analyzer rules that exposed two code style violations in test files:

  • IDE0044: Field should be readonly
  • IDE0048: Missing parentheses for operator precedence clarity

Solution

  • MockInstallerFactory.cs: Made _factoryId field readonly since it's only assigned at initialization
  • XunitLoggerProvider.cs: Added parentheses around null-coalescing expression for correct precedence
// Before
messageBuilder.AppendLine(firstLinePrefix + lines.FirstOrDefault() ?? string.Empty);

// After  
messageBuilder.AppendLine(firstLinePrefix + (lines.FirstOrDefault() ?? string.Empty));

Checks:

  • Added unit tests

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Nov 25, 2025
Merged
Copilot AI and others added 3 commits November 25, 2025 22:12
@marcpopMSFT
Fix IDE0044 and IDE0048 build errors in test files
d9cea8f 
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
@marcpopMSFT
Fix IDE0044 and IDE0048 build errors in test files
66c2b44 
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
@marcpopMSFT
Remove accidentally committed nuget.exe
6f115fb 
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 11vvsblobprodcus336.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/AB88DE0132B6D75989D697FA80071392/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 1s1vsblobprodcus386.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/AB88DE0132B6D75989D697FA80071392/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/71CDA9FA07BF67921CD59B3ABBA37B0E/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/2C284E924AAA368B86377B61F57BA4C1/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 2kmvsblobprodcus39.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/AB88DE0132B6D75989D697FA80071392/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • 7devsblobprodcus323.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/77C2B7EFA55E8BDA0B153C2537FBB3C8/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • fdpvsblobprodcus345.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/AB88DE0132B6D75989D697FA80071392/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • i1qvsblobprodcus353.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/77C2B7EFA55E8BDA0B153C2537FBB3C8/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • imzvsblobprodcus368.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/77C2B7EFA55E8BDA0B153C2537FBB3C8/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • k4kvsblobprodcus344.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/E14C8BA0FF1586483BD6B71B290C5072/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • m8dvsblobprodcus37.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/97C00D1D1F52251A513DE1D1C4C4B56A/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • n3kvsblobprodcus335.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/2C284E924AAA368B86377B61F57BA4C1/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • o3svsblobprodcus318.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.Mocks/Microsoft.TemplateEngine.Mocks.csproj --no-restore (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.csproj --no-restore (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/templating/Microsoft.TemplateEngine.sln --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot (dns block)
  • pe3vsblobprodcus354.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/2C284E924AAA368B86377B61F57BA4C1/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • rcxvsblobprodcus328.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.TestHelper/Microsoft.TemplateEngine.TestHelper.csproj --no-restore (dns block)
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.TemplateEngine.Mocks/Microsoft.TemplateEngine.Mocks.csproj --no-restore (dns block)
  • s8mvsblobprodcus38.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/97C00D1D1F52251A513DE1D1C4C4B56A/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • st8vsblobprodcus339.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/EE9D343C76C38EDF0AC64A832F8C101A/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)
  • vwvvsblobprodcus334.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/E14C8BA0FF1586483BD6B71B290C5072/missingpackages_workingdir --packages /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /home/REDACTED/work/templating/.codeql-scratch/dbs/csharp/working/nugetconfig/nuget.config --force (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update dependencies from dotnet/arcade [release/8.0.1xx] Update dependencies from dotnet/arcade Nov 25, 2025
Copilot AI requested a review from marcpopMSFT November 25, 2025 22:19
@marcpopMSFT marcpopMSFT marked this pull request as ready for review November 26, 2025 00:15
@marcpopMSFT marcpopMSFT requested a review from a team as a code owner November 26, 2025 00:15
@marcpopMSFT marcpopMSFT merged commit c86b28e into darc-release/8.0.1xx-f6e867c1-48f5-42dd-816b-a2309476fb1f Nov 26, 2025
2 checks passed
This was referenced Dec 9, 2025
Closed
Closed
Closed
Closed
Merged
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 17, 2025
Merged
@dotnet-maestro dotnet-maestro bot mentioned this pull request Jan 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

Assignees

@marcpopMSFT marcpopMSFT

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcpopMSFT