Enable source-build prebuilt detection #5582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dotnet/source-build-internal, @mmitche, @oleksandr-didyk |
vlada-shubina
requested changes
Nov 9, 2022
Member
|
@MichaelSimons Looks like there are real issues with the upgrade of some dependencies |
ef535a3 to
d68e649
Compare
Comment on lines
14
to
16
| <PackageReference Update="Microsoft.Extensions.Logging" Condition="'$(MicrosoftExtensionsLoggingVersion)' != ''" Version="$(MicrosoftExtensionsLoggingVersion)" /> | ||
| <PackageReference Update="Microsoft.Extensions.Logging.Console" Condition="'$(MicrosoftExtensionsLoggingConsoleVersion)' != ''" Version="$(MicrosoftExtensionsLoggingConsoleVersion)" /> | ||
| <PackageReference Update="Microsoft.Extensions.Logging.Abstractions" Condition="'$(MicrosoftExtensionsLoggingAbstractionsVersion)' != ''" Version="$(MicrosoftExtensionsLoggingAbstractionsVersion)" /> |
Member
There was a problem hiding this comment.
Is it still needed?
iirc, this makes source build to use the versions from the repo which are latest release; same as regular build.
Member
Author
There was a problem hiding this comment.
I think you are correct. I added these back.
vlada-shubina
approved these changes
Dec 19, 2022
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5177 and #5519
Problem
source-build prebuilt detection is not enabled. Enabling this will hopefully catch any source-build prebuilts in PR validation and prevent issue like #5519
Solution
Enabled source-build prebuilt detection by removing the "*" entry in https://github.com/dotnet/templating/blob/main/eng/SourceBuildPrebuiltBaseline.xml. I then made the missing Version.Details.xml dependencies to eliminate any reported prebuilts.
I lifted the Microsoft.Extensions.Logging to the most recent versions via the darc dependency flow. This eliminates the need for using source-build ref packages as described in #5177.