Skip to content

do not enable nullable on netstandard2.0#3299

Merged
vlada-shubina merged 3 commits intodotnet:release/6.0.1xx-preview6from
jmarolf:do-not-turn-on-nullable-for-netstandard
Jun 19, 2021
Merged

do not enable nullable on netstandard2.0#3299
vlada-shubina merged 3 commits intodotnet:release/6.0.1xx-preview6from
jmarolf:do-not-turn-on-nullable-for-netstandard

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented Jun 17, 2021

fixes #3297

@jmarolf jmarolf requested a review from a team as a code owner June 17, 2021 22:55
@jmarolf jmarolf force-pushed the do-not-turn-on-nullable-for-netstandard branch from 7771e31 to 6e6a85d Compare June 17, 2021 23:47
@jmarolf jmarolf requested a review from dsplaisted June 18, 2021 01:12
@jmarolf jmarolf force-pushed the do-not-turn-on-nullable-for-netstandard branch from 52eb405 to 6e6a85d Compare June 18, 2021 01:14
Copy link
Copy Markdown
Member

@vlada-shubina vlada-shubina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarolf thanks, looks good.
I will push couple other tests shortly.
Preview 6 is already in approval mode - will you request approval or should I?

@vlada-shubina vlada-shubina added the servicing-consider The issue to be considered for servicing label Jun 18, 2021
@vlada-shubina vlada-shubina merged commit 8615f76 into dotnet:release/6.0.1xx-preview6 Jun 19, 2021
@vlada-shubina vlada-shubina mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

servicing-consider The issue to be considered for servicing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants