Skip to content

TestPlatform 15.7 preview 1 template changes#1430

Closed
abhishkk wants to merge 5 commits intodotnet:rel/2.1.0-preview2from
abhishkk:testPlatformInsertion
Closed

TestPlatform 15.7 preview 1 template changes#1430
abhishkk wants to merge 5 commits intodotnet:rel/2.1.0-preview2from
abhishkk:testPlatformInsertion

Conversation

@abhishkk
Copy link
Copy Markdown
Contributor

@abhishkk abhishkk commented Feb 26, 2018

Release notes here.
VS insertion PR here.
Dot net CLI PR here.

@mlorbetske Is release/2.1 right branch for VS 15.7 preview 1?
Also, Is there any other branch in which I need to port these changes?

@dnfclas
Copy link
Copy Markdown

dnfclas commented Feb 26, 2018

CLA assistant check
All CLA requirements met.

@mlorbetske
Copy link
Copy Markdown
Contributor

mlorbetske commented Feb 26, 2018

The appropriate branch for content changes is always the active dev branch (in this case rel/2.1.0-preview2), content changes from there will flow to master and the current release branch. For the 2.1 runtime carrying CLI, these changes will flow automatically, however, for the 2.0 and 1.x runtime carrying CLIs, there'll need to be insertions of the templates into that branch after the build of the content packages becomes available.

I'll retarget these changes to rel/2.1.0-preview2.

@abhishkk if you would rebase these changes on the the rel/2.1.0-preview2 so that only your changes are included, that'd be great.

@seancpeters when we have a green PR build, please merge rel/2.1.0-preview2 to the master and release/2.1 branches. After we have a good build, please insert the test templates into the CLI's release/2.1.2xx branch.

@livarcocc what branch of CLI should changes for the 1.x test templates go in to for 15.7 preview 1? Also, from the mail thread, are there branches for the 2.0 and 1.x runtime carrying CLIs for 15.6 where we could insert the appropriate test templates as well?

@mlorbetske mlorbetske changed the base branch from release/2.1 to rel/2.1.0-preview2 February 26, 2018 18:19
@abhishkk
Copy link
Copy Markdown
Contributor Author

abhishkk commented Feb 26, 2018

@mlorbetske Thanks for the info. Even after re-targeting to rel/2.1.0-preview2, PR contains my changes only. Is there any action item on me?

@mlorbetske
Copy link
Copy Markdown
Contributor

mlorbetske commented Feb 26, 2018

@abhishkk I see 4 other commits listed, it’d be nice if it only had the one

@abhishkk
Copy link
Copy Markdown
Contributor Author

New PR targeting rel/2.1.0-preview2.

@abhishkk abhishkk closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants