StrongName Sign assemblies before Authenticode signing#1372
Merged
Conversation
joeloff
reviewed
Dec 9, 2017
build.proj
Outdated
|
|
||
| <MSBuild Condition="'$(PB_SignType)' == 'real' or '$(PB_SignType)' == 'test'" | ||
|
|
||
| <!-- String name the localized assemblies--> |
Member
There was a problem hiding this comment.
Typo :) should be Strongname, not String name
joeloff
approved these changes
Dec 9, 2017
Member
joeloff
left a comment
There was a problem hiding this comment.
I assume the neutral assembly is already StrongName signed before doing Authenticode?
Contributor
Author
|
yes, strong name signing happens as part of build and authenticode signing happens after that. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joeloff