Merged
Conversation
8 tasks
tmat
reviewed
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ARM64 support to the library.
In addition to the functional change there are a few cosmetic changes. That was done because I brought this file in sync with the dotnet/roslyn version of the file. Now that the target framework is netstandard2.0 there is no reason for the files to differ anymore. Seemed to make sense to unify them. Can remove the cosmetic changes if you prefer.
Unfortunately there is no queue in Helix today that is generally available for ARM64 testing. I manually validated this change on an ARM64 machine by dropping it into Roslyn tests that were failing on
Pdb2Xmland verifying that they passed after this change.I used process inspection to double check that it actually did run the ARM64 version of the test runner