Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Seal types that cannot be inherited#1183

Merged
terrajobst merged 1 commit intodotnet:masterfrom
terrajobst:more-sealed-types
May 15, 2019
Merged

Seal types that cannot be inherited#1183
terrajobst merged 1 commit intodotnet:masterfrom
terrajobst:more-sealed-types

Conversation

@terrajobst
Copy link
Copy Markdown

@terrajobst terrajobst commented May 9, 2019

These changes are related to #1176 and address the same problem.

Fixes #1171.

@terrajobst terrajobst requested review from a team as code owners May 9, 2019 22:26
@terrajobst terrajobst added the netstandard-api This tracks requests for standardizing APIs. label May 9, 2019
@terrajobst terrajobst added this to the .NET Standard 2.1 milestone May 9, 2019
@terrajobst terrajobst force-pushed the more-sealed-types branch from 8c09b91 to 2a91c9e Compare May 9, 2019 22:33
@terrajobst terrajobst requested review from Anipik and ericstj May 10, 2019 18:32
Anipik
Anipik approved these changes May 10, 2019
View reviewed changes
Copy link
Copy Markdown

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrajobst
Copy link
Copy Markdown
Author

terrajobst commented May 15, 2019

@onovotny @jaredpar @stephentoub PTAL

wtgodbe
wtgodbe suggested changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should rebase on top of #1180 & re-run the build, we may get more APICompat baseline changes in this PR after my change.

@terrajobst terrajobst force-pushed the more-sealed-types branch from 2a91c9e to 0901b7b Compare May 15, 2019 20:57
@terrajobst terrajobst requested a review from wtgodbe May 15, 2019 20:57
@terrajobst
Copy link
Copy Markdown
Author

terrajobst commented May 15, 2019 •
edited
Loading

You should rebase on top of #1180 & re-run the build, we may get more APICompat baseline changes in this PR after my change.

I rebased onto master but didn't see any changes upon rebuild.

Turns out, rebase isn't nearly as useful as a rebase following a pull 🙄

@terrajobst terrajobst force-pushed the more-sealed-types branch from 0901b7b to f58ef6c Compare May 15, 2019 21:02
Seal types that cannot be inherited
4ddf8f5 
These changes are related to 9681af and address the same problem.

Fixes dotnet#1171.
@terrajobst terrajobst force-pushed the more-sealed-types branch from f58ef6c to 4ddf8f5 Compare May 15, 2019 21:07
wtgodbe
wtgodbe approved these changes May 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrajobst
Copy link
Copy Markdown
Author

terrajobst commented May 15, 2019

@jaredpar I'm merging due to overwhelming sign-off. Please find me and punish me in person if you disagree :-)

@terrajobst terrajobst merged commit 4f12869 into dotnet:master May 15, 2019
@terrajobst terrajobst deleted the more-sealed-types branch May 15, 2019 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

7 more reviewers

@joshpeterson joshpeterson joshpeterson approved these changes

@marek-safar marek-safar marek-safar approved these changes

@clairernovotny clairernovotny clairernovotny approved these changes

@stephentoub stephentoub stephentoub approved these changes

@ericstj ericstj ericstj approved these changes

@Anipik Anipik Anipik approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

netstandard-api This tracks requests for standardizing APIs.

Projects

None yet

Milestone

.NET Standard 2.1

Development

Successfully merging this pull request may close these issues.

BaseNumberConverter should be effectively sealed

8 participants

@terrajobst @joshpeterson @marek-safar @clairernovotny @stephentoub @ericstj @Anipik @wtgodbe