Fix packaging of Microsoft.Build.StandardCI #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing an official build, DebugType is portable which causes the IncludeSymbols flag in src/Directory.Build.props to evaluate to true. The Microsoft.Build.StandardCI project uses the Microsoft.Build.NoTargets SDK which doesn't produce a build output (as the package only ships a content file and not a binary). Change the condition to check if the NoTargets SDK is used which indicates that a symbol shouldn't be included.
Closed
tmat
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1044
When performing an official build, DebugType is portable which causes the IncludeSymbols flag in src/Directory.Build.props to evaluate to true. The Microsoft.Build.StandardCI project uses the Microsoft.Build.NoTargets SDK which doesn't produce a build output (as the package only ships a content file and not a binary). Change the condition to check if the NoTargets SDK is used which indicates that a symbol shouldn't be included.