Skip to content

Misleading reference to SetSourceRevisionId target #725

New issue
New issue
Closed
#735
Closed
Misleading reference to SetSourceRevisionId target#725
#735
@KalleOlaviNiemitalo

Description

@KalleOlaviNiemitalo
KalleOlaviNiemitalo
opened on Aug 1, 2021

docs/README.md claims that the SetSourceRevisionId target sets the SourceRevisionId property:

sourcelink/docs/README.md

Lines 141 to 144 in 4b584db

### SourceRevisionId
Set by target `SetSourceRevisionId` and consumed by NuGet `Pack` target and `GenerateAssemblyInfo` target.
May be used by custom targets that need this information.

However, there is no SetSourceRevisionId target. It seems the SourceRevisionId property is instead set by the InitializeSourceControlInformationFromSourceControlManager target, or without a target:

sourcelink/src/Microsoft.Build.Tasks.Git/build/Microsoft.Build.Tasks.Git.targets

Line 32 in 4b584db

<Output TaskParameter="RevisionId" PropertyName="SourceRevisionId" Condition="'$(SourceRevisionId)' == ''" />

sourcelink/src/Microsoft.Build.Tasks.Tfvc/build/Microsoft.Build.Tasks.Tfvc.targets

Line 29 in 4b584db

<Output TaskParameter="RevisionId" PropertyName="SourceRevisionId" />

sourcelink/src/Microsoft.Build.StandardCI/build/Microsoft.Build.StandardCI.props

Line 25 in 4b584db

<SourceRevisionId Condition="'$(SourceRevisionId)' == ''">$(STANDARD_CI_SOURCE_REVISION_ID)</SourceRevisionId>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions