Skip to content

Add reference projects for new Roslyn dependencies #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViktorHofer merged 4 commits into from
Oct 15, 2025
Merged

Add reference projects for new Roslyn dependencies #1416

ViktorHofer merged 4 commits into from
Oct 15, 2025

Conversation

Copy link
Contributor

Copilot AI commented Oct 15, 2025 •
edited
Loading

This PR adds reference packages for the new Roslyn dependencies required by dotnet/dotnet#2842 (comment).

Packages Added

The following reference packages have been generated:

  • Microsoft.Build, 17.11.31
  • Microsoft.Build.Framework, 17.11.31
  • Microsoft.Build.Tasks.Core, 17.11.31
  • Microsoft.Build.Utilities.Core, 17.11.31
  • Microsoft.NET.StringTools, 17.11.31
  • System.Reflection.MetadataLoadContext, 8.0.0

The generator also automatically created the following dependency packages required by the above:

  • System.Configuration.ConfigurationManager, 8.0.0
  • System.Diagnostics.EventLog, 8.0.0
  • System.Resources.Extensions, 8.0.0
  • System.Security.Cryptography.ProtectedData, 8.0.0
  • System.Threading.Tasks.Dataflow, 8.0.0

Note: Microsoft.Build.Locator 1.10.2 is handled as an external package using the existing submodule infrastructure (already at SHA 694ff392b2dcf6ac58fe865afd1c982eb9449014) rather than as a reference package.

Technical Changes

Generator Limitation Fixes

Added customization files to address known generator issues:

  • microsoft.build/17.11.31/Customizations.cs - The generator doesn't emit all members of the IBuildEventArgsReaderNotifications interface. Added missing ArchiveFileEncountered and StringReadDone event implementations.

  • system.configuration.configurationmanager/8.0.0/Customizations.cs - The generator references System.Security.PermissionSet in netstandard2.0 but doesn't include it as a dependency. Added a stub type to allow compilation.

Cleanup

Reverted unintended regeneration changes to system.security.cryptography.xml/8.0.0 that removed IndexerName attributes, which would have caused compilation errors.

Verification

All packages build successfully and produce valid NuGet packages in artifacts/packages/Release/ReferenceOnly/.

Fixes #1415

Original prompt

This section details on the original issue you should resolve

<issue_title>Add reference projects for new Roslyn dependencies</issue_title>
<issue_description>As mentioned in dotnet/dotnet#2842 (comment), reference projects need to be generated for the following packages.

Microsoft.Build,17.11.31
Microsoft.Build.Framework,17.11.31
Microsoft.Build.Locator,1.10.2
Microsoft.Build.Tasks.Core,17.11.31
Microsoft.Build.Utilities.Core,17.11.31
Microsoft.NET.StringTools,17.11.31
System.Reflection.MetadataLoadContext,8.0.0
```</issue_description>

<agent_instructions>Follow the instructions in the Readme.md to generate new reference projects.</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes #1415

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits October 15, 2025 16:09
@JoeRobich
Add strong name key for MSBuildLocator and generate reference packages
3899daf 
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
@JoeRobich
Add customizations for MSBuildLocator, Microsoft.Build, and System.Co…
2017255 
…nfiguration.ConfigurationManager

Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copilot AI changed the title [WIP] Add reference projects for new Roslyn dependencies Add reference projects for new Roslyn dependencies Oct 15, 2025
Copilot AI requested a review from JoeRobich October 15, 2025 16:24
@JoeRobich
Copy link
Member

JoeRobich commented Oct 15, 2025

@copilot I was wrong about Microsoft.Build.Locator. It should be treated as an external package. Please remove the microsoft.build.locator reference package and signing key changes that you made. Please set the MSBuildLocator submodule to the following SHA 694ff392b2dcf6ac58fe865afd1c982eb9449014 and update patches as necessary.

@JoeRobich
Remove Microsoft.Build.Locator reference package and treat it as exte…
102ca27 
…rnal package

Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 15, 2025

@copilot I was wrong about Microsoft.Build.Locator. It should be treated as an external package. Please remove the microsoft.build.locator reference package and signing key changes that you made. Plea...

Done. Removed the microsoft.build.locator reference package and all related signing key changes. The MSBuildLocator submodule is already at SHA 694ff392b2dcf6ac58fe865afd1c982eb9449014 and the existing patches apply cleanly. Changes committed in 0b42c59.

@JoeRobich JoeRobich marked this pull request as ready for review October 15, 2025 17:43
@JoeRobich JoeRobich requested a review from a team as a code owner October 15, 2025 17:43
@JoeRobich JoeRobich mentioned this pull request Oct 15, 2025
Merged
@JoeRobich JoeRobich requested a review from ViktorHofer October 15, 2025 17:46
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 15, 2025

@JoeRobich the Microsoft.Build.Locator submodule update was already handled via #1403

@ViktorHofer ViktorHofer merged commit 11bd2bd into main Oct 15, 2025
4 checks passed
@ViktorHofer ViktorHofer deleted the copilot/add-reference-projects-roslyn-dependencies branch October 15, 2025 18:02
@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 15, 2025

/backport to release/10.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Started backporting to release/10.0: https://github.com/dotnet/source-build-reference-packages/actions/runs/18538154062

@github-actions github-actions bot mentioned this pull request Oct 15, 2025
Merged
This was referenced Oct 16, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

+1 more reviewer

@JoeRobich JoeRobich JoeRobich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoeRobich JoeRobich

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add reference projects for new Roslyn dependencies

3 participants

@JoeRobich @ViktorHofer